Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix fixes #322

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Nix fixes #322

merged 3 commits into from
Jan 7, 2025

Conversation

fufexan
Copy link
Contributor

@fufexan fufexan commented Jan 7, 2025

  • format all nix files using alejandra. I can add it as the default formatter as well. If you prefer a different formatter, that can also be done.
  • structure packages inside overlay for easier management and overrideability (especially considering the recent hatch breakage)
  • update lockfile (needed for rust 1.83)
  • temporary fix for hatch build failure (can be reverted once Build failure: hatch NixOS/nixpkgs#366359 is solved)

@R1kaB3rN
Copy link
Member

R1kaB3rN commented Jan 7, 2025

Looks good to me. Also, I created a package request for pyzstd upstream. Once that's merged we can add another patch to not vendor pyzstd.

cc @beh-10257 just so that you're aware.

@R1kaB3rN
Copy link
Member

R1kaB3rN commented Jan 7, 2025

format all nix files using alejandra. I can add it as the default formatter as well. If you prefer a different formatter, that can also be done.

Sure, that's fine. That way, there'll be a standard format which I think is good.

@R1kaB3rN R1kaB3rN merged commit f423d66 into Open-Wine-Components:main Jan 7, 2025
12 checks passed
@beh-10257
Copy link
Contributor

nice thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants