Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix mypy return Any #325

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

R1kaB3rN
Copy link
Member

@R1kaB3rN R1kaB3rN commented Jan 8, 2025

Related to https://github.com/Open-Wine-Components/umu-launcher/actions/runs/12677716535/job/35333669712

Trivial and not serious. Just cannot reproduce locally within the venv.

@R1kaB3rN
Copy link
Member Author

R1kaB3rN commented Jan 8, 2025

Strange. Cannot reproduce using mypy 1.14.1 in a virtual environment.

$ mypy --version
mypy 1.14.1 (compiled: yes)
$ which mypy
/home/foo/umu-launcher/.venv/bin/mypy
$ python --version
Python 3.10.16
$ which python
/home/foo/umu-launcher/.venv/bin/python
$ mypy umu/
Success: no issues found in 11 source files

- This is a strange, harmless bug that cannot be reproduced locally in a venv, and is uninteresting to delve into. Once ruff's red knot is merged and works fine, will consider getting rid of this
@R1kaB3rN R1kaB3rN marked this pull request as ready for review January 8, 2025 20:17
@R1kaB3rN
Copy link
Member Author

R1kaB3rN commented Jan 8, 2025

There's 2k+ issues in the mypy issue tracker, and querying with the relevant error string currently returns 34 issues related to this. Ignoring, and won't fix.

@R1kaB3rN R1kaB3rN merged commit 0e23aaf into Open-Wine-Components:main Jan 8, 2025
12 checks passed
@R1kaB3rN R1kaB3rN deleted the fix-mypy branch January 8, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant