Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guide for nixos install #327

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

darshanCommits
Copy link
Contributor

closes #324

NixOs stable(nixpkgs 24.11) rustc version is at 1.82 which was causing the issue.
Tho, is 1.83 really needed? Rust MSRV should be lower for easier packaging upstream.

@R1kaB3rN
Copy link
Member

No, we don’t. Thanks for pointing that out. Yes, the MSRV is able to be downgraded as far as 1.81, which will allow Fedora and Nobara to use its system rustc.

@R1kaB3rN R1kaB3rN mentioned this pull request Jan 10, 2025
@R1kaB3rN
Copy link
Member

R1kaB3rN commented Jan 10, 2025

Fixed the MSRV to something reasonable MSRV (1.65) for now at 414a1a8. Again, thanks for pointing that out.

cc @beh-10257 for awareness of this change.

@R1kaB3rN R1kaB3rN merged commit e9cb4d7 into Open-Wine-Components:main Jan 10, 2025
12 checks passed
@darshanCommits
Copy link
Contributor Author

I think this PR should be reverted as msrv has been downgraded.
Since afaik inputs.nixpkgs.follows = "nixpkgs"; is for package coherence, actual issue was just msrv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nix: rustc versioning, unable to build.
2 participants