Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version flag to launcher #33

Closed
wants to merge 5 commits into from

Conversation

R1kaB3rN
Copy link
Member

@R1kaB3rN R1kaB3rN commented Feb 20, 2024

Adds a version flag to launcher and prints the release version of the CLI as well as its associated tooling that are defined in the TOML config file -- ULWGL_VERSIONS.toml.

Example of ULWGL_VERSIONS.toml:

# Required. We expect this table
[ulwgl.versions]
# Required. We expect this key
launcher = "1.0"
# All other key value pairs can be anything and we just print them all
reaper = "1.0" 
pressure_vessel = "1.0"
runtime = "sniper"

NOTE: This file needs to be included in the release.

For the config. we check the current directory for the file and /usr/share/ULWGL. In case of absence, nothing will be printed.

As a result, versions for our tools are centralized and we avoid hard coding version names in scripts. In addition, the version config files can be autogenerated via a Github Action

- There's no reason we should do this since we do not call it anywhere within parse_args
- Be sure we check the 'launcher' key is there. Otherwise we could raise an KeyError
- It doesn't quite make sense to return a non-zero status code on success.
@GloriousEggroll
Copy link
Member

lgtm just leaving open in case toml handling changes due to #37

Feel free to merge once that's resolved.

@R1kaB3rN R1kaB3rN marked this pull request as draft February 21, 2024 00:51
@R1kaB3rN R1kaB3rN closed this Feb 21, 2024
@R1kaB3rN R1kaB3rN deleted the version branch March 9, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants