-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make parsing configuration files a plugin #38
Conversation
ba0ec06
to
94109c3
Compare
That was fast! I would suggest to add all versions from 3.7 onwards since lutris supports them. |
We could test that far, but is it fine to use Lutris as our baseline? They must have different requirements to test that far |
Since lutris uses ulwgl i would say yes. We lose nothing doing it anyways. Better be safe. |
While we have nothing to lose, I don't quite agree with that logic and would prefer that we have more precise reasons for testing that far Also, if we really want to decisively solve this problem, we have the Flatpak to bundle dependencies that will cover not only Python, but Mesa and Vulkan which DXVK has hard minimum requirements for. But luckily, Jammy sources the minimum Mesa for to use DXVK for gaming to not be a big problem for those users |
ecc47ba
to
79da459
Compare
Imho the Mesa version requirement for DXVK is irrelevant. Someone might choose to use the OpenGL renderer for whatever reason, or install and use things like gallium nine (I have not tested that option with Proton but you get the point). Someone else might want to chip in here though. |
- Since tomllib requires Python 3.11, only run the config tests for 3.11+ - Related to Open-Wine-Components#37
80ed051
to
2a1e440
Compare
Closes #37
This PR separates the config file functionality as a plugin from the core program to make it run on some distributions (e.g. Ubuntu LTS).
tomllib
will be dynamically imported, optional and in the event the user tries to use the--config
flag, an error will be raised to warn them of the Python requirement.cc @loathingKernel for the Github Action