Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fixes for YUZUSOFT titles #115

Merged
merged 7 commits into from
Aug 31, 2024

Conversation

R1kaB3rN
Copy link
Member

Related to #111

@R1kaB3rN
Copy link
Member Author

CC @layercak3.

A review would be appreciated.

@R1kaB3rN R1kaB3rN changed the title Update fixes for YUZUSOFT titles" Update fixes for YUZUSOFT titles Aug 29, 2024
@layercak3
Copy link

I don't think 2458530 should be changed as it is untested. 888790 needs -vomstyle=overlay (util.append_argument) to avoid random crashes. I honestly cannot surely recommend changing these for protonfixes's audience in general in case of performance issues with other hardware/steam deck (creeperofdoom) or future regressions if new work is pushed to bleeding-edge, when the wmp11 fixes are mentioned to work just fine for people on protondb/elsewhere. I am using the built-in libraries personally because I have the means to test/debug before playing and don't rely on protonfixes.

@R1kaB3rN R1kaB3rN marked this pull request as draft August 30, 2024 01:56
@CreeperofDoom
Copy link
Contributor

CreeperofDoom commented Aug 31, 2024

The new fix works fine, but...

I tested the title Riddle Joker:
One user reported there is a Pixelation issue with the WMP Video Files which i dont know how to fix, applying the vomstyle launch command breaks Video Playback.

On my end Video Playback has ocassional audio issues. With the audio going behind in seconds in the playing video randomly and then going back to where its suppose to, over and over

Sometimes the audio cuts off and on during Video Playback

The old one with the WMP stuff worked perfect it seemed. But Upgrading GE-Proton would break it, requiring the Proton Data to be cleared to remedy it.

Performance Issues are caused by a broken Pre-Compiled Shader Cache. Deleting that and booting Riddle Joker offline fixes the problem (going online on Steam will force a redownload of the broken cache, Coming at 5 Gigabytes)

@R1kaB3rN
Copy link
Member Author

R1kaB3rN commented Aug 31, 2024

If it works, that's fine. Compared to the old fix, this new one would be preferred as it avoids having new users from manually clearing Proton-related data for future wine prefix upgrades. The wmp11 verb will need to be thoroughly investigated and resolved separately at another time.

We run winetricks verbs to fix games, and should be perceived as temporary workarounds until there's a solution upstream. Therefore, if a decent native solution (e.g., gstreamer bad plugins, winegstreamer) exists, it should always be preferred over dubious binaries sourced from winetricks verbs.

As for potential regressions from wine that may effect playback, that's something everyone who uses GE-Proton should be prepared for and what's certain is that video playback will be broken after the wine prefix upgrade if we choose not to update these fixes. If there happens to be a regression in winegstreamer, as always, the problem should be reported upstream and we can always reintroduce the old fix in the future when necessary.

@R1kaB3rN R1kaB3rN marked this pull request as ready for review August 31, 2024 05:14
@R1kaB3rN R1kaB3rN merged commit 0d33bbe into Open-Wine-Components:master Aug 31, 2024
1 check passed
@R1kaB3rN R1kaB3rN deleted the yuzusoft branch August 31, 2024 05:23
@CreeperofDoom
Copy link
Contributor

CreeperofDoom commented Sep 7, 2024

IMG_5658
I get this when attempting to play one of the Video Files in Riddle Joker. GE-Proton 9-13 Used.
I tried clearing the Proton Data and that didn’t fix it. Why doesn’t it work anymore? In The prior version it worked and when i wrote the New Fix to test it worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants