refactor: prefer pathlib when possible #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6818b6b.
R1kaB3rN
commented
Dec 19, 2024
| os.path.join(script_dir, 'game_title'), # noqa: PTH118 | ||
| 'w', | ||
| encoding='utf-8', | ||
| ) as file: | ||
| file.write(title) |
There was a problem hiding this comment.
This might be a bug. If I'm understanding correctly, we're not writing the title in the user's prefix. Instead, the title's is in the protonfixes directory.
R1kaB3rN
commented
Dec 19, 2024
| file.write(title) | ||
| return title | ||
| except FileNotFoundError: | ||
| log.warn(f"CSV file not found: {csv_file_path}") | ||
| log.warn(f'CSV file not found: {csv_file_path}') |
There was a problem hiding this comment.
Just style changes applied from ruff format.
R1kaB3rN
commented
Dec 19, 2024
| return False | ||
|
|
||
| # Ensure local gamefixes are importable as modules via PATH | ||
| with open(os.path.join(localpath, '__init__.py'), 'a', encoding='utf-8'): | ||
| sys.path.append(os.path.expanduser('~/.config/protonfixes')) | ||
| with open(os.path.join(localpath, '__init__.py'), 'a', encoding='utf-8'): # noqa: PTH118, PTH123 |
There was a problem hiding this comment.
Do we even have to open the file here?
R1kaB3rN
commented
Dec 19, 2024
|
|
||
| try: | ||
| with open(csv_file_path, newline='', encoding='utf-8') as csvfile: | ||
| with open(csv_file_path, newline='', encoding='utf-8') as csvfile: # noqa: PTH123 | ||
| csvreader = csv.reader(csvfile) |
There was a problem hiding this comment.
The CSV is a database for us so we should handle the CSV by assuming it's very large.
TODO: Refactor to prefer memory mapping the CSV in a future PR.
R1kaB3rN
commented
Dec 19, 2024
| @@ -129,16 +132,16 @@ def get_module_name(game_id: str, default: bool = False, local: bool = False) -> | |||
|
|
|||
| def _run_fix_local(game_id: str, default: bool = False) -> bool: | |||
| """Check if a local gamefix is available first and run it""" | |||
| localpath = os.path.expanduser('~/.config/protonfixes/localfixes') | |||
| localpath = os.path.expanduser('~/.config/protonfixes/localfixes') # noqa: PTH111 | |||
There was a problem hiding this comment.
Refactoring this line and below as pathlib.Path objects should be safe.
R1kaB3rN
commented
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #152 and #50.
Refactors to use pathlib when possible or appropriate without directly affecting user-created gamefixes