-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Annotations for shellcheck and ruff + enable pyright (without static type checking) #205
base: master
Are you sure you want to change the base?
CI: Annotations for shellcheck and ruff + enable pyright (without static type checking) #205
Conversation
Why doesn't pyright error on resolution? |
I expected the warning:
to have the workflow fail, which doesn't. I guess it's just a matter of configuring pyright? |
Github checks against unchanged files I guess. Therefore these are only warnings.. or the warning level is not high enough / pyright doesn't fail.
Yeah.. they aren't errors. I think we could configure pyright to handle them as errors. |
Yeah, we can look into that later. |
I changed the configuration to be as strict as possible regarding imports and handle everything as an error. PS: It's expected, that the CI fails. That's fixed with #200. |
This prevents subsequent errors and fixes errors thrown by static code analysis.
- enable static type checking via pyright-action - added pyproject.toml with basic meta data and pyright configuration - use action-shellcheck instead of installing it manually - use ruff-action instead of installing it manually - Cache pip dependencies
ad92f42
to
44d4f5f
Compare
Using the symbolic link in combination with Or have you tested the changes in #200 and concluded that they work and are indeed a "better" solution? :) BTW: Since the gamefixes work inside proton / |
Cherry-picked and adopted from #152
As discussed in #204 Pyright is able to check the imports, without checking types. I'm not sure what else is tested, but imports are.