Type import for oneOf models in ts-fetch template #16828
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for some compilation modes of TS, specifically for use with SvelteKit.
The error I'm getting when using the generated code on SvelteKit is:
Those options are deliberate and mandatory according to SvelteKit's doc.
As such I've made a change to the way types are imported, which actually already seems to be present in
modelGeneric
. This change is conclusive on my end and makes the generated code work in my project.Now, to be perfectly transparent, I am extremely not used to the tooling of this project and I have no idea if did everything right. Specifically, I think I managed to run some tests but it stays pretty elusive to me, so let me know what/how I should fix it (and how can I avoid having
cargo
and a million other tools installed on my machine).This seems to be a PR for @CodeNinjai, @frol and @cliffano
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)