Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type import for oneOf models in ts-fetch template #16828

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

Xowap
Copy link
Contributor

@Xowap Xowap commented Oct 14, 2023

Required for some compilation modes of TS, specifically for use with SvelteKit.

The error I'm getting when using the generated code on SvelteKit is:

TS1444:  XXX  is a type and must be imported using a type-only import when  preserveValueImports  and  isolatedModules  are both enabled.

Those options are deliberate and mandatory according to SvelteKit's doc.

As such I've made a change to the way types are imported, which actually already seems to be present in modelGeneric. This change is conclusive on my end and makes the generated code work in my project.

Now, to be perfectly transparent, I am extremely not used to the tooling of this project and I have no idea if did everything right. Specifically, I think I managed to run some tests but it stays pretty elusive to me, so let me know what/how I should fix it (and how can I avoid having cargo and a million other tools installed on my machine).

This seems to be a PR for @CodeNinjai, @frol and @cliffano

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Required for some compilation modes of TS, specifically for use with SvelteKit.
@wing328
Copy link
Member

wing328 commented Nov 1, 2023

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)

@macjohnny macjohnny merged commit 5c5ec36 into OpenAPITools:master Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants