Fix postman test, update logback to newer version #17329

wing328 · 2023-12-06T06:59:31Z

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package 
./bin/generate-samples.sh ./bin/configs/*.yaml
./bin/utils/export_docs_generators.sh
```
(For Windows users, please run the script in Git BASH)
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

wing328 · 2023-12-06T07:18:39Z

...i-generator/src/test/java/org/openapitools/codegen/postman/PostmanCollectionCodegenTest.java

@@ -786,7 +786,7 @@ public void testQueryParameterDescription() throws IOException {
        output.deleteOnExit();

        final CodegenConfigurator configurator = new CodegenConfigurator()
-                .setGeneratorName("postman-v2")
+                .setGeneratorName("postman-collection")
                .setInputSpec("./src/test/resources/SampleProject.yaml")


@gcatanese can you please take a look at this line when you've time? SampleProject.yaml is a config file but not an OpenAPI spec.

Same issue in line 766

Sorry, I made a mistake re-using a test on a local implementation (I did miss the CI failures though). The test file is "src/test/resources/3_0/postman-collection/SampleProject.yaml"

what about replacing these tests with a workflow in github to test the output (postman collection) with a Python/JS script instead?

The unit tests allow me to test before pushing (this is why I cannot believe I miss this), but the idea of a Github workflow seems good. What is the idea:

remove/reduce this type of testing?

Python script on Github? Can you elaborate or provide an example? I can look into it and make a PR

can you please PM me via Slack to further discuss this?

This was removed in #16802, but using a higher value than 1, or at least making this configurable makes complete sense. Without this, we get a lot of these log messages: [ WARNING] Connection pool is full, discarding connection:

gcatanese · 2023-12-06T08:58:20Z

...i-generator/src/test/java/org/openapitools/codegen/postman/PostmanCollectionCodegenTest.java

@@ -786,7 +786,7 @@ public void testQueryParameterDescription() throws IOException {
        output.deleteOnExit();

        final CodegenConfigurator configurator = new CodegenConfigurator()
-                .setGeneratorName("postman-v2")
+                .setGeneratorName("postman-collection")


@wing328 Indeed it should be

.setGeneratorName("postman-collection") .setInputSpec("src/test/resources/3_0/postman-collection/SampleProject.yaml")

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: ddd <ddd>

Fixes #17264

* [csharp] Support 420 HTTP code * [csharp] Support 420 HTTP code * [csharp] Support 420 HTTP code * [csharp] Support 420 HTTP code * [csharp] Support 420 HTTP code

* Add optional parameter for request body * Adapt Test * Add test * Format code * Remove extra method * Add optional for pojos * Add optional for pojos * Add bean validation for Optional * Add default values + test * Rename test

* fix: go-server unresolved function NewstringFromValue for enums * fix: go-server change isRef to isEnumRef in controller-api template

* Fix broken link to csharp-netcore generator The example source URL of the csharp-netcore generator pointed to the master version of the repo, but the generator has been renamed or removed and the URL is broken. I updated the link to the latest pre 5.0.0 version, since the text talks about pre 5.0.0 version of the openapi generator. * Update link to point to csharp generator

* Ruby Client for Faraday: fix file downloading In MR #16876, a bug was introduced that causes file downloading to fail for the Faraday adapter. This commit fixes the obvious missing parameter for the method call to download_file() and the missing variable `request` for saving the response value of the call to build_request(). Signed-off-by: Daniel Schnell <[email protected]> * Add automatically generated changes. --------- Signed-off-by: Daniel Schnell <[email protected]>

* add new ruby echo api clients * add tests for ruby faraday file download * add file download test to ruby Typhoeus * add ruby workflow, add tests for ruby httpx * update * fix

* fix: change indent style to tab in the mustache to generate Go code * docs: standardize the language names for code blocks * docs: change indent style to tab in the code blocks * update: regenerate samples * `./bin/generate-samples.sh ./bin/configs/*.yaml`

…17358)

* Add support for webhooks * Test webhook generation with Go Gin server * Generate samples * Removing \t * Remove tabs

* Created kotlin jvm spring restclient * Fixed kotlin jvm-spring-restclient * Fixed earlier problems * Fixed earlier problems * Updated kotlin.md

* [csharp][generichost] Handle obsolete params and methods * update samples --------- Co-authored-by: William Cheng <[email protected]>

* fix NPE in the example generator * fix any type in 3.1 spec * use log error instead

@Valid

…7165) * [4947][java]: adds support for validation of primitives in arrays * [4947][java]: prevents generation '@Valid' for Object * [4947][java]: test against different codegens and stick to primitive * [4947][java]: code review * [4947][java]: enhance getBeanValidation * [4947][java]: adds email * [4947][java]: removes unnecessary override * [4947][java]: adds postProcessResponseWithProperty * [4947][java]: adds missing import {{javaxPackage}}.validation.Valid * [4947][java]: adds missing useBeanValidation * [4947][java]: fix use rootJavaEEPackage for helidon

* Implementing retry logic to restTemplate * Fixing the issue * Adding import * Fix * Fix * minor update, add tests * fix * Adding the maxRetryAttempt, threadWaitTime as additionalProperty * Updating the apiClient * Removing reduntant variable * Generating samples * Fixing format --------- Co-authored-by: Rubini <[email protected]> Co-authored-by: William Cheng <[email protected]>

…y string parameters (#17386) * Add check for input if is Map type * Update Pet samples * Add PetApi support for filter by Pet property * Clean up * update samples * remove manual test --------- Co-authored-by: ameenhaq <[email protected]>

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(java): apache-httpclient serialization error fixes following related issue: #12797 * docs(java): update samples and docs

gcatanese · 2023-12-17T13:43:40Z

See #17412 17412

* Add Python tests * Add workflow to verify Postman samples * Correct path

The modelNameMappings were introduced with PRs #16209, #16234 and are now also used in the ruby client generator.

* Add missing Jackson converter for Retrofit This commit adds the missing configuration for a ApiClient so all Jackson serializations will start to work correctly. * Add sample project code for Retrofit Jackson

* implemented generalized content-type handling * regenerated samples * addressed implementation review feedback * added tests for proposed improvements

…#17436)

* fix(typescript-*): nullable additionalProperty values * chore(samples): update samples

…nerator into fix-test

wing328 requested a review from jimschubert as a code owner December 6, 2023 06:59

fix postman test, update logback to newer version

51bf0cd

wing328 commented Dec 6, 2023

View reviewed changes

gcatanese reviewed Dec 6, 2023

View reviewed changes

wing328 and others added 25 commits December 6, 2023 17:50

add enum name mapping to ada codegen (#17299)

2c9fbf8

Use .Content of for accessing response body in powershell (#17342)

3762277

fix(typescript-axios): use baseURL of (custom) axios instance (#17296)

e37cf90

Co-authored-by: ddd <ddd>

[typescript-axios] Allow enum attribute to be nullable (#17265)

c159abf

Fixes #17264

[csharp] Support 420 HTTP code (#17207)

6246235

* [csharp] Support 420 HTTP code * [csharp] Support 420 HTTP code * [csharp] Support 420 HTTP code * [csharp] Support 420 HTTP code * [csharp] Support 420 HTTP code

fix: go-server unresolved function NewstringFromValue for enums (#17316)

95af601

* fix: go-server unresolved function NewstringFromValue for enums * fix: go-server change isRef to isEnumRef in controller-api template

enable scopes for all security scheme types (#17083)

a21e681

check boolean value returned by createFile (#17359)

5daa145

update logbak core to newer version (#17360)

dd36fa0

[Ruby] add file download tests (#17362)

10da7a3

* add new ruby echo api clients * add tests for ruby faraday file download * add file download test to ruby Typhoeus * add ruby workflow, add tests for ruby httpx * update * fix

[kotlin-client][multiplatform] use shortcut to access jsMain as well (#…

8bb9a10

…17358)

OpenAPI 3.1.0 Add webhooks support (#17174)

9eb5882

* Add support for webhooks * Test webhook generation with Go Gin server * Generate samples * Removing \t * Remove tabs

[kotlin-client] New generator: kotlin-jvm-spring-restclient (#17366)

7f05c1f

* Created kotlin jvm spring restclient * Fixed kotlin jvm-spring-restclient * Fixed earlier problems * Fixed earlier problems * Updated kotlin.md

[csharp][generichost] Handle obsolete params and methods (#17344)

51c8be3

* [csharp][generichost] Handle obsolete params and methods * update samples --------- Co-authored-by: William Cheng <[email protected]>

add a test for SecretStr in the python client (#17364)

62399b1

Better handling of any type in v3.1 spec (#17370)

d4d5196

* fix NPE in the example generator * fix any type in 3.1 spec * use log error instead

[C][Client] Use int* as int or bool type function parameter (#17179)

2a27fd5

tiffmaelite and others added 11 commits December 13, 2023 15:07

add security feature AWSV4Signature to documentation (#15603)

42f7219

update doc

56e2c49

Regenerate (#17389)

b7f31dd

Do not escape request name (#17394)

0062d1c

fix: java apache httpclient should support UTF-8 by default (#17395)

a9179e9

* fix(java): apache-httpclient serialization error fixes following related issue: #12797 * docs(java): update samples and docs

deref parameter in normalizer for 3.1 spec (#17406)

367301d

fix #16889 replace deprecated response code function (#17405)

e63563a

remove auto-generated ruby tests (#17402)

809d715

gcatanese and others added 11 commits December 18, 2023 10:52

[POSTMAN] Add Samples GitHub workflow (#17412)

58345a9

* Add Python tests * Add workflow to verify Postman samples * Correct path

Use modelNameMappings in ruby client (#17408)

efe2f87

The modelNameMappings were introduced with PRs #16209, #16234 and are now also used in the ruby client generator.

Fix missing convertor for jackson in retrofit (#17418)

5435b44

* Add missing Jackson converter for Retrofit This commit adds the missing configuration for a ApiClient so all Jackson serializations will start to work correctly. * Add sample project code for Retrofit Jackson

to fix loop for allof with single element in normalizer (#17426)

473c350

fix missing array description in 3.1 spec (#17427)

dc047b4

Generalized mime type support (#17285)

aacea34

* implemented generalized content-type handling * regenerated samples * addressed implementation review feedback * added tests for proposed improvements

Add "cronn GmbH" to the list of companies using the openapi-generator (…

1ccabee

…#17436)

update wording in exception message (python abstract) (#17437)

aeb6fcb

fix(typescript-*): nullable additionalProperty values (#17379)

457622c

* fix(typescript-*): nullable additionalProperty values * chore(samples): update samples

Add tests to verify generated Postman samples (#17444)

b5cd4e9

fix exception in request body with enum ref (#17438)

a62132e

wing328 added Enhancement: Compatibility Feature: Generator labels Dec 21, 2023

wing328 added 3 commits December 21, 2023 15:25

fix postman test, update logback to newer version

ca49ed2

update swagger parser to newer version

ac95ec0

Merge branch 'fix-test' of https://github.com/OpenAPITools/openapi-ge…

fc12baa

…nerator into fix-test

wing328 closed this Dec 21, 2023

wing328 deleted the fix-test branch December 21, 2023 07:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix postman test, update logback to newer version #17329

Fix postman test, update logback to newer version #17329

wing328 commented Dec 6, 2023

wing328 Dec 6, 2023

wing328 Dec 6, 2023

gcatanese Dec 6, 2023

wing328 Dec 6, 2023

gcatanese Dec 6, 2023

wing328 Dec 6, 2023

gcatanese Dec 6, 2023

gcatanese commented Dec 17, 2023

Fix postman test, update logback to newer version #17329

Fix postman test, update logback to newer version #17329

Conversation

wing328 commented Dec 6, 2023

PR checklist

wing328 Dec 6, 2023

Choose a reason for hiding this comment

wing328 Dec 6, 2023

Choose a reason for hiding this comment

gcatanese Dec 6, 2023

Choose a reason for hiding this comment

wing328 Dec 6, 2023

Choose a reason for hiding this comment

gcatanese Dec 6, 2023

Choose a reason for hiding this comment

wing328 Dec 6, 2023

Choose a reason for hiding this comment

gcatanese Dec 6, 2023

Choose a reason for hiding this comment

gcatanese commented Dec 17, 2023