fix: change to debug-logging for logging request headers in ApiClient #17332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
Dec 7, 2023
| @@ -834,7 +834,7 @@ public class ApiClient{{#jsr310}} extends JavaTimeFormatter{{/jsr310}} { | |||
| private void logRequest(HttpRequest request, byte[] body) throws UnsupportedEncodingException { | |||
| log.info("URI: " + request.getURI()); | |||
| log.info("HTTP Method: " + request.getMethod()); | |||
| log.info("HTTP Headers: " + headersToString(request.getHeaders())); | |||
| log.debug("HTTP Headers: " + headersToString(request.getHeaders())); | |||
There was a problem hiding this comment.
for your use case, you only want to skip one particular line in the log.
What about using customized templates (e.g. -t via CLI) instead?
There was a problem hiding this comment.
Thank you for the guidance!
My intention was also to prevent the inclusion of Base64 encoded secrets as "info" in the logs. Shouldn't this solution be applicable to every user, rather than being specific to just my case?
|
I discovered that this logs only occurre when setting "debug" for APIClient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to debug-logging for logging Request-Headers during ApiClient calls.
Fixes #17331