Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Java] Add Generated annotations to more classes #17736

Merged

Conversation

jo1gi
Copy link
Contributor

@jo1gi jo1gi commented Jan 29, 2024

Fixes #17735

Adds Generated annotations to:

  • RFC3339DateFormat
  • ServerConfiguration
  • ServerVariable
  • ApiResponse
  • ClassDiscriminatorMapping in JSON.mustache
  • TypeReference in api.mustache

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Mentions: @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

@jo1gi jo1gi force-pushed the issue-17735-missing-generated-annotations branch from cdcf72d to 271bcf8 Compare January 31, 2024 09:49
@martin-mfg
Copy link
Contributor

Thanks for the PR!
It mostly looks good to me. But what is the intention behind GenericTypeRef?

@jo1gi
Copy link
Contributor Author

jo1gi commented Feb 5, 2024

But what is the intention behind GenericTypeRef?

The inline TypeReference classes are also flagged if they don't have a Generated annotation. Creating a single TypeReference class (GenericTypeRef) was simpler than annotating all inline TypeReference classes.

@jo1gi jo1gi force-pushed the issue-17735-missing-generated-annotations branch from 271bcf8 to bed2517 Compare February 7, 2024 10:11
@jo1gi jo1gi force-pushed the issue-17735-missing-generated-annotations branch from bed2517 to f00e6e1 Compare February 12, 2024 08:54
@jo1gi jo1gi requested a review from wing328 February 12, 2024 11:06
@jo1gi jo1gi requested a review from martin-mfg March 18, 2024 10:55
@wing328 wing328 merged commit 3cb3fc2 into OpenAPITools:master Apr 9, 2024
4 checks passed
@wing328 wing328 modified the milestones: 8.0.0, 7.5.0 Apr 9, 2024
@wing328
Copy link
Member

wing328 commented Apr 9, 2024

@jo1gi looks like this break the build: https://github.com/OpenAPITools/openapi-generator/actions/runs/8612824195/job/23602824257

can you please take a look when you've time?

@wing328
Copy link
Member

wing328 commented Apr 10, 2024

fixed in the latest master but there's another issue with JDK11 as the code now throws exception during runtime.

i've filed #18346 to revert back to TypeReference for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [JAVA] Missing Generated annotations on classes
3 participants