-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Go] Set Default Values for Required Variables when a default is defined #19232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
f373304
to
25c2656
Compare
samples/openapi3/client/petstore/go/go-petstore/model_category.go
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/go/model_simple.mustache
Outdated
Show resolved
Hide resolved
for the failing test, please update the assertion accordingly as the |
I have removed the setting of the value and Getter is a pure getter as it should have been. So, this is not required anymore. |
please run https://github.com/OpenAPITools/openapi-generator/blob/master/bin/utils/ensure-up-to-date to update the doc as well |
@wing328 I had missed out running the exporting of docs post resolving the comments. It is done now. And all the tests are passing. |
looks good. let's give it a try |
…ned (OpenAPITools#19232) * use default values for required vars when available * update tests to existing config file * cleanup OAS test * Remove setting value in Get. * Use Pascal Case for variable naming in Getter Function * add a CLI option * add a CLI option * add a CLI option
…ned (OpenAPITools#19232) * use default values for required vars when available * update tests to existing config file * cleanup OAS test * Remove setting value in Get. * Use Pascal Case for variable naming in Getter Function * add a CLI option * add a CLI option * add a CLI option
…ned (OpenAPITools#19232) * use default values for required vars when available * update tests to existing config file * cleanup OAS test * Remove setting value in Get. * Use Pascal Case for variable naming in Getter Function * add a CLI option * add a CLI option * add a CLI option
Fixes #19107
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)