Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes required for ORDER_PAYMENT network message #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changes required for ORDER_PAYMENT network message #3

wants to merge 2 commits into from

Conversation

amangale
Copy link

@amangale amangale commented Aug 2, 2019

This is wrt ob-go PR1654.

placer14
placer14 approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM with minor change.

wallet.go
addr = nil
} else {
addr = addrs[0]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addr is already nil.

@placer14
Copy link
Member

placer14 commented Aug 6, 2019

We're no longer supporting this package. Closing this PR as unneeded. See OpenBazaar/openbazaar-go#1672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placer14 placer14 placer14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amangale @placer14