Switch to cmake-build-extension, Support Windows #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have no idea why.
It still uses release for temporary directory name on windows and I'm not entirely sure this is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently using custom code to allow the setup to invoke CMake to build the native Python extension. cmake-build-extension, which didn't exist when the PyOpenDDS was created, can now take over that role. It requires the
cmakePyPi package, so it sorta forces the CMake part of #29. It also apparently has some extra functionality where it can install native dependencies so it might also eventually be used to help solve the OpenDDS part of #29.Some better CMake support also makes it easier to support Windows with some a little more work on the other parts of PyOpenDDS, which partially addresses #35.