Bugfix: on idle detection reset movement-based sensor data.

Fixes #1995.
OpenTracksApp · Dec 17, 2024 · fd9646b · fd9646b
1 parent 4966ba8
commit fd9646b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 11 deletions.
diff --git a/src/main/java/de/dennisguse/opentracks/sensors/sensorData/Aggregator.java b/src/main/java/de/dennisguse/opentracks/sensors/sensorData/Aggregator.java
@@ -55,7 +55,9 @@ public Output getValue() {
     /**
      * Reset long term aggregated values (more than derived from previous SensorData). e.g. overall distance.
      */
-    public void reset() {}
+    public void reset() {
+        value = getNoneValue();
+    }
 
     /**
      * Is the data recent considering the current time.

diff --git a/src/main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorBarometer.java b/src/main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorBarometer.java
@@ -37,10 +37,5 @@ protected AltitudeGainLoss getNoneValue() {
         return new AltitudeGainLoss(0f, 0f);
     }
 
-    @Override
-    public void reset() {
-        value = getNoneValue();
-    }
-
     public record Data(Altitude gain, Altitude loss) {}
 }
diff --git a/src/main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorGPS.java b/src/main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorGPS.java
@@ -16,11 +16,6 @@ protected void computeValue(Raw<Position> current) {
         value = current.value();
     }
 
-    @Override
-    public void reset() {
-        value = null;
-    }
-
     @NonNull
     @Override
     protected Position getNoneValue() {

diff --git a/src/main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorHeartRate.java b/src/main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorHeartRate.java
@@ -15,6 +15,11 @@ protected void computeValue(Raw<HeartRate> current) {
         this.value = current.value();
     }
 
+    @Override
+    public void reset() {
+        // We don't need to reset the heart rate as this value is valid for a certain amount of time: and it is not an aggregate.
+    }
+
     @NonNull
     @Override
     protected HeartRate getNoneValue() {