Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: Mandatory recursive submodules #48

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Mionsz
Copy link
Collaborator

@Mionsz Mionsz commented Jan 22, 2025

ADD: Mandatory recursive submodules:

  • submodules/Video-Super-Resolution-Library
  • submodules/SVT-JPEG-XS
  • submodules/Media-Communications-Mesh

@skolelis
Copy link
Collaborator

LGTM

@Mionsz Mionsz added the ready for review The labeled PR is ready to be reviewed. label Jan 22, 2025
skolelis
skolelis previously approved these changes Jan 22, 2025
Copy link
Collaborator

@skolelis skolelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to the last release commit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were the latest version when added, submodules are always pinned to the commit hash at needs to be updated from time to time.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, but the latest version and the last release commit are not the same in this case. It is important to refer to the released version.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

submodules/Video-Super-Resolution-Library Show resolved Hide resolved
submodules/SVT-JPEG-XS Show resolved Hide resolved
@Mionsz Mionsz force-pushed the private/mlinkiew/submodules-added branch from c782c32 to 7e0c98c Compare January 24, 2025 15:44
@awilczyns awilczyns force-pushed the private/mlinkiew/submodules-added branch from 7e0c98c to ba4142f Compare January 29, 2025 15:33
ADD: Mandatory recursive submodules:
- submodules/Video-Super-Resolution-Library
- submodules/SVT-JPEG-XS
- submodules/Media-Communications-Mesh

Signed-off-by: Milosz Linkiewicz <[email protected]>
@Mionsz Mionsz force-pushed the private/mlinkiew/submodules-added branch from ba4142f to 115ac9f Compare February 6, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The labeled PR is ready to be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants