Update other todo comments.

Opentrons · Dec 23, 2024 · 466900f · 466900f
1 parent a981719
commit 466900f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/robot-server/robot_server/persistence/tables/schema_2.py b/robot-server/robot_server/persistence/tables/schema_2.py
@@ -62,7 +62,6 @@
     sqlalchemy.Column(
         "completed_analysis",
         # Stores a pickled dict. See CompletedAnalysisStore.
-        # TODO(mm, 2023-08-30): Remove this. See https://opentrons.atlassian.net/browse/RSS-98.
         sqlalchemy.LargeBinary,
         nullable=False,
     ),

diff --git a/robot-server/robot_server/protocols/analysis_models.py b/robot-server/robot_server/protocols/analysis_models.py
@@ -141,9 +141,9 @@ class CompletedAnalysis(BaseModel):
 
     # Fields that should match local analysis:
     robotType: Optional[RobotType] = Field(
-        # robotType is deliberately typed as a Literal instead of an Enum.
-        # It's a bad idea at the moment to store enums in robot-server's database.
-        # https://opentrons.atlassian.net/browse/RSS-98
+        # robotType was typed as a Literal instead of an Enum because it was a bad idea
+        # at the time to store enums in robot-server's database
+        # (https://opentrons.atlassian.net/browse/RSS-98).
         default=None,  # default=None to fit objects that were stored before this field existed.
         description=(
             "The type of robot that this protocol can run on."