feat(api): driver and simulator for FLEX Stacker #17120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
approved these changes
Dec 16, 2024
| _RE = re.compile(f"^{GCODE.GET_LIMIT_SWITCH} {pattern}") | ||
| m = _RE.match(response) | ||
| if not m: | ||
| raise ValueError(f"Incorrect Response for limit siwtch status: {response}") |
There was a problem hiding this comment.
Suggested change
| raise ValueError(f"Incorrect Response for limit siwtch status: {response}") | |
| raise ValueError(f"Incorrect Response for limit switch status: {response}") |
verify the gcode responses and match exact pattern
vegano1
deleted the
EXEC-980-flex-stacker-driver-skeleton-in-opentrons-driver
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a driver and a simulator for the FLEX Stacker that follow the same pattern as the other Opentrons modules.
The driver is in charge of sending commands to the device via serial communication, and parsing the responses into data that can be understood by the robot.
What's Next?
I'll implement Stacker module control interface in the hardware controller layer that makes use of the driver.