Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix back to back manual move commands on desktop app #17129

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Dec 17, 2024

Closes RQA-3728

Overview

Since the introduction of the move labware intervention deck map, chaining back to back move interventions has posed a challenge, see comments in #13005.

The setTimeout solution proposed in the linked PR effectively worked, and this code looks like it got dropped at some point. However, there are other ways of doing the same thing that are more React Spring-esque, using the API's reset property.

Current Behavior

2024-12-02_14-00-55.mp4

Fixed Behavior

Screen.Recording.2024-12-17.at.3.10.46.PM.mov

Test Plan and Hands on Testing

  • See video. Verified using QA's protocol probably like 20 times.

Changelog

  • Fixed back-to-back intervention modals sometimes moving labware to interesting places.

Risk assessment

low

@mjhuff mjhuff requested a review from a team as a code owner December 17, 2024 21:27
@mjhuff mjhuff requested review from TamarZanzouri, a team, sfoster1 and smb2268 and removed request for a team December 17, 2024 21:27
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gross but good!

@mjhuff mjhuff merged commit 2084121 into edge Dec 18, 2024
64 checks passed
@mjhuff mjhuff deleted the app_back-to-back-manual-move-fix branch December 18, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants