Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update vitest and vitest-when #17149

Merged
merged 5 commits into from
Dec 20, 2024
Merged

chore: update vitest and vitest-when #17149

merged 5 commits into from
Dec 20, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Dec 19, 2024 •
edited
Loading

Overview

update vitest and vitest-when

close AUTH-1197

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

@koji koji marked this pull request as ready for review December 20, 2024 15:51
@koji koji requested review from a team as code owners December 20, 2024 15:51
mjhuff
mjhuff approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple clean up comments. Thank you for doing this!

package.json Outdated Show resolved Hide resolved
protocol-designer/src/__tests__/persist.test.ts Outdated Show resolved Hide resolved
@koji koji merged commit 04dea6c into edge Dec 20, 2024
60 checks passed
@koji koji deleted the chore_update-vitest-version-and-vitest-when branch December 20, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhuff mjhuff mjhuff approved these changes

@sfoster1 sfoster1 Awaiting requested review from sfoster1

@smb2268 smb2268 Awaiting requested review from smb2268

@ncdiehl11 ncdiehl11 Awaiting requested review from ncdiehl11

@jerader jerader Awaiting requested review from jerader

@shlokamin shlokamin Awaiting requested review from shlokamin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koji @mjhuff