Added Social Profiles #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariobehling
reviewed
Jan 8, 2020
mariobehling
requested changes
Jan 8, 2020
|
@mariobehling Sir I had removed that as it had been typed twice this it was showing 2 Facebook profiles for the same account. I this removed one. If you look above that line in the index.html page you can see that the Facebook link is already present there. What I removed was a copy of the same link so that it would be displayed only once on the social profile. |
|
Sir please review. |
mariobehling
approved these changes
Jan 8, 2020
|
Thanks. Please help to revert this PR as well: fossasia/fossasia.org#621 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix issue #42 .
I have added links to various blogs and social profiles of some of the speakers in the FOSSASIA OpenTechSummit Thailand as well as updated some of the social profiles of the FOSSASIA team.
Apart from this in one of the profiles the Facebook link was being shown twice due to an error in the html file. I have also resolved this issue.
@mariobehling @hpdang Mentors please review the above merge request as and when possible.