This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Add custom terminationgraceperiodseconds #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you wanna set the default to empty or something while this is fixed in the image? |
|
Despite it is useless with the travelaudience docker image, i think it can be useful when you use official image : therefore we can let this PR as is |
|
My only issue is having it default to 120 seconds knowing it isn't doing anything when using the default values of the chart. I'd rather disable it or greatly reduce it and put some notes in the Readme. |
added 2 commits
May 12, 2021 15:47
|
Hi @rjkernick ! I pushed a new version based on your advices, is it ok for you ? Best regards, |
rjkernick
approved these changes
Jun 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customizing terminationgraceperiodseconds maybe helpful to prevent Orientdb corruption during stop/start actions (eg : upgrade)
Edit : after some tests, this PR seems to be unusable because of this issue : travelaudience/docker-nexus#56