Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change EquipGearset detour, and add OnStateUpdated IPC Event. #103

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

CordeliaMist
Copy link

@CordeliaMist CordeliaMist commented Jan 19, 2025

This PR adds the following changes:

Detours EquipGearsetInternal instead of EquippedGearset

  • Allows the gearset event to trigger when switching between gearsets on the same job, if the gearset you switch to is activated via the Hotbar.

Adds a new IPC Method, OnStateUpdated()

  • Event will allow other plugins to know whenever Glamourer has performed all necessary state changes to a target actor for a given operation.
  • Helps in cases where plugins do not need to care about each individual change that occurs, but rather need to know when the initial changes through any operation finish occurring (that may or may not affect the actor with multiple state Changes)

OnStateUpdated() Can account for any of the following Glamourer Operations completing:

  • Individual Design Application
  • Model Change
  • Game State Reset
  • Customize Reverted (Independently)
  • Equipment Reverted (Independently)
  • Advanced Data Reverted (Independently)
  • Revert Automation
  • Reapply State (Manually invoked basic reapplies and redraws)
  • Reapply Automation (Also fires from any OnAutomationChange)
  • Gearset (Also Triggered by other players initial first load of their game state)

The necessary API Integration for this addition is already made into a PR on the API here: Ottermandias/Glamourer.Api#2

All of the signatures and parsed unknown structs are currently in a PR for client structs so that you will soon be able to remove the bloat and replace it with member function detours relatively soon!
PR: aers/FFXIVClientStructs#1277

…y marks reverts and gearsets. Replaced back excessive logging to maintain with logging formats expected by glamourer.
Ensures that ReapplyAutomation is called from OnAutomationChange when change occurs.
Reformatted temporary Signature locations and comments to align with the structure of the respective classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant