Skip to content

Commit

Permalink
Updating to make the @magenta/music 1.23.0 work
Browse files Browse the repository at this point in the history
  • Loading branch information
Ryan Louie committed Nov 18, 2021
1 parent 49a0491 commit 5b5677f
Show file tree
Hide file tree
Showing 5 changed files with 299 additions and 63 deletions.
30 changes: 0 additions & 30 deletions configs/webpack/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,23 +45,6 @@ module.exports = {
test: /\.tsx?$/,
use: [
{ loader: 'cache-loader' },
{
loader: 'thread-loader',
options: {
// there should be 1 cpu for the fork-ts-checker-webpack-plugin
workers: require('os').cpus().length - 1,
poolTimeout: Infinity, // set this to Infinity in watch mode - see https://github.com/webpack-contrib/thread-loader
},
},
{
loader: 'babel-loader',
options: {
cacheDirectory: true,
babelrc: false,
presets: ['@babel/preset-env', '@babel/preset-react'],
plugins: ['react-hot-loader/babel'],
},
},
{
loader: 'ts-loader',
options: {
Expand Down Expand Up @@ -89,21 +72,8 @@ module.exports = {
],
},
plugins: [
new ForkTsCheckerWebpackPlugin({
checkSyntacticErrors: true,
tsconfig: resolve(__dirname, '../../tsconfig.json'),
exclude: '',
}),
new Dotenv(),
new HtmlWebpackPlugin({ inject: true, template: 'index.html.ejs' }),
new AutoDllPlugin({
inject: true, // will inject the DLL bundles to index.html
filename: dllFilename,
entry: {
vendor: vendorDependencies,
},
context: resolve(__dirname, '../../src'),
}),
],
performance: {
hints: false,
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"webpack-merge": "^4.2.1"
},
"dependencies": {
"@magenta/music": "1.9.0",
"@magenta/music": "^1.23.1",
"@material-ui/core": "^4.0.0",
"@material-ui/icons": "^4.0.0",
"@material-ui/lab": "^4.0.0-alpha.13",
Expand Down
2 changes: 1 addition & 1 deletion src/core/player.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class Player {

private player = new mm.SoundFontPlayer(
SOUNDFONT_URL,
Tone.master,
Tone.Destination,
undefined,
undefined,
this.playerCallbackObject
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"sourceMap": true,
"noImplicitAny": false,
"module": "commonjs",
"target": "es5",
"target": "es6",
"jsx": "react",
"lib": ["es5", "es6", "dom"],
"experimentalDecorators": true,
Expand Down
Loading

0 comments on commit 5b5677f

Please sign in to comment.