Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patches: Load and list patches for ELFs with a Disc Path set #12128

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Patches: Load and list patches for ELFs with a Disc Path set #12128

wants to merge 3 commits into from
+38 −18

Conversation

CookiePLMonster
Copy link
Contributor

Description of Changes

This PR improves the behaviour of the game list for ELFs loaded with the "backing" ISO set by the Disc Path. The following changes were made:

  1. If the serial is not known, patches/cheats no longer try to use the empty serial. This previously resulted in PCSX2 attempting to load files with the filename format _crc.pnach, which, coincidentally, resulted in my "disabled" pnachs loading as I disabled some by prefixing them with an underscore.
  2. If the serial is not known, All CRCs in Patches and Cheats is greyed out as it's meaningless.
  3. If Disc Path is set, use the serial from that disc when populating the cheat and patch lists. This makes the UI behaviour match what PCSX2 was doing when loading the game - previously, these patches were loaded, but it was not possible to enable them from the UI. This change does not change the INI file name for the ELF game settings!
  4. Additionally, changing the Disc Path now toggles the state of the Check Wiki button in the Game Summary.

image

Fixes #11533.

Rationale behind Changes

Consistency between the UI behaviour and what happens when you load the game.

Suggested Testing Steps

See #11533 for suggested steps.

@CookiePLMonster
Patch: When serial is empty, don't match files on empty serial
ad89010 
Fixes a bug where _crc.pnach files matched the regex if serial
was not set. Also grey out "All CRCs" when serial is not set,
as the option is then meaningless.
@CookiePLMonster
Qt/Patches: Use the game list serial when populating patches for the ELF
f2488df 
This makes the Game Properties window match the behaviour of the VM
when booting into a game.

Fixes PCSX2#11533
@CookiePLMonster
Qt/Patches, Cheats: Reload lists if serial changes
4ff1691
@CookiePLMonster CookiePLMonster mentioned this pull request Dec 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
GUI/Qt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Game loaded using 'Host Filesystem' ignores cheat pnach file.
1 participant
@CookiePLMonster