Fixed fonts in the generated file after usiong a reader #793
Conversation
|
I'm experiencing this issue, it's throwing the exception because the panose is already 020B0604020202020204 instead of 2B64222224. Instead of removing the len check we could check if it's 20 before throwing the exception, if it is, it runs a logic that cuts the padded zeros. |
|
@xlar8or Could you rebase your PR against the master branch, please? Thanks |
Seems to work, thanks! I'm stil having having issues where the save of a pptx is broken (vertical text instead of horizontal text, wrong font size, shapes aren't saved, image sizes aren't the same, audio/video isn't saved, etc), so it doesn't seem to be related with panose. I've already commented on this issue in #837 so hopefully you'll be able to look at that soon, because due to this issue it unfortunantely makes the library unusable to output a pptx that isn't fully made with the library functions and uses slides from another pptx. |
|
Yeah. I would like to merge this PR for fixing font issues and continue on issues next week. So i need you rebase your PR with the font issue fix. |
I've replaced my entire library with the latest master and the panose fix works, so that's all good on my side. I didn't do the PR that was @ag3202. |
Discovered a font issue in the scenario of importing and then exporting, not sure about other scenarios. Unclear about the handling of Panose length and adding zeros, as Panose can easily exceed 10, and not very familiar with using dechex. After fixing, the font displays correctly, placing a:latin in a:ea results in the font displaying correctly after modification.