Skip to content

Commit

Permalink
Tweak One Test
Browse files Browse the repository at this point in the history
Fluke failure in CI push.
  • Loading branch information
oleibman committed Jan 15, 2025
1 parent 6e5bbcd commit 173ff7b
Showing 1 changed file with 21 additions and 7 deletions.
28 changes: 21 additions & 7 deletions tests/PhpSpreadsheetTests/Document/PropertiesTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class PropertiesTest extends TestCase

private float $startTime;

protected function setup(): void
protected function setUp(): void
{
do {
// loop to avoid rare situation where timestamp changes
Expand Down Expand Up @@ -49,9 +49,16 @@ public function testSetCreator(): void
*/
public function testSetCreated(null|int $expectedCreationTime, null|int|string $created): void
{
$expectedCreationTime = $expectedCreationTime ?? $this->startTime;

$this->properties->setCreated($created);
if ($expectedCreationTime === null) {
do {
// loop to avoid rare situation where timestamp changes
$expectedCreationTime = (float) (new DateTime())->format('U');
$this->properties->setCreated($created);
$endTime = (float) (new DateTime())->format('U');
} while ($expectedCreationTime !== $endTime);
} else {
$this->properties->setCreated($created);
}
self::assertEquals($expectedCreationTime, $this->properties->getCreated());
}

Expand All @@ -78,9 +85,16 @@ public function testSetModifier(): void
*/
public function testSetModified(mixed $expectedModifiedTime, null|int|string $modified): void
{
$expectedModifiedTime = $expectedModifiedTime ?? $this->startTime;

$this->properties->setModified($modified);
if ($expectedModifiedTime === null) {
do {
// loop to avoid rare situation where timestamp changes
$expectedModifiedTime = (float) (new DateTime())->format('U');
$this->properties->setModified($modified);
$endTime = (float) (new DateTime())->format('U');
} while ($expectedModifiedTime !== $endTime);
} else {
$this->properties->setModified($modified);
}
self::assertEquals($expectedModifiedTime, $this->properties->getModified());
}

Expand Down

0 comments on commit 173ff7b

Please sign in to comment.