-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DGO support for Chromecast #587
Conversation
Adds DGO launcher support for chromecast devices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greetings @baukita!
I've reviewed your pull request, but I need to insist on many changes before it can be merged. Please use the following and re-submit your request:
"dgo": {
"button": '<svg xmlns="http://www.w3.org/2000/svg" width="850" height="308" viewBox="0 0 850 308" stroke="#000" stroke-linecap="round" stroke-linejoin="round" fill="#fff" fill-rule="evenodd"><defs><linearGradient id="AFuW" x1=".057%" x2="138.034%" y1="50.013%" y2="50.013%"><stop offset="0%" stop-color="#00aeef"/><stop offset="100%" stop-color="#005993"/></linearGradient></defs><g fill-rule="nonzero" stroke="none"><path d="M711 16c-76 0-138 61-138 137s62 137 137 137a136.57 136.57 0 0 0 137-137c1-75-61-137-136-137zm0 213c-31 0-59-19-71-47-11-28-5-61 17-83 22-21 54-28 83-16 28 12 47 39 47 70 0 20-8 40-23 54-14 14-33 22-53 22zm-153-77c0-11-1-21-4-31h-82c-28 0-51 23-51 51v5c0 4 4 7 8 7h61c-16 34-53 52-89 42s-60-45-55-82c4-37 34-65 72-67h35c31 0 56-25 56-56 0-1-1-2-2-3s-2-2-4-2h-85c-76 2-135 64-134 139 1 76 63 137 138 136 76 0 137-62 136-138z" fill="#f58220"/><path d="M264 153c0 84-69 152-155 153H12c-2 0-4-1-5-3-2-1-2-3-2-5 6-37 38-64 76-64h28c43 0 75-31 79-73v-8-6c-4-42-37-75-80-75H81c-20 0-40-8-54-22C15 39 8 25 5 9c0-2 0-4 2-6 1-1 3-2 5-2h95c86 0 156 68 157 152z" fill="#00aeef"/><path d="M183 152c0 40-16 79-45 108-28 29-66 45-107 45H7c-2 0-4-1-5-3-2-1-2-3-2-5 6-37 37-64 74-64h27c42 0 77-32 80-74 1-3 1-5 0-8v-4c-3-43-38-76-81-76H74c-20 0-39-8-53-22C10 38 3 24 0 8c0-2 0-4 2-5 1-2 3-3 5-3h23c84 0 152 68 153 152z" fill="url(#AFuW)" transform="translate(5 1)"/><path d="M66 154c0 25 20 45 46 45a44.81 44.81 0 0 0 45-45c0-26-20-46-45-46-26 0-46 20-46 46z" fill="#f58220"/></g></svg>',
"friendlyName": "DGO",
"className": "dgoButton",
"deviceFamily": ["amazon-fire", "chromecast", "homatics", "nvidia-shield", "onn", "xiaomi"],
"amazon-fire": {
"appName": 'com.directv.dtvlatam',
"androidName": 'com.directv.dtvlatam',
"adbLaunchCommand": "adb shell am start -n com.directv.dtvlatam/com.directvgo.feature.tv.splash.SplashActivity"
},
"chromecast": {
"appName": 'com.directv.dtvlatam',
"androidName": 'com.directv.dtvlatam',
"adbLaunchCommand": "adb shell am start -n com.directv.dtvlatam/com.directvgo.feature.tv.splash.SplashActivity"
},
"homatics": {
"appName": 'com.directv.dtvlatam',
"androidName": 'com.directv.dtvlatam',
"adbLaunchCommand": "adb shell am start -n com.directv.dtvlatam/com.directvgo.feature.tv.splash.SplashActivity"
},
"nvidia-shield": {
"appName": 'com.directv.dtvlatam',
"androidName": 'com.directv.dtvlatam',
"adbLaunchCommand": "adb shell am start -n com.directv.dtvlatam/com.directvgo.feature.tv.splash.SplashActivity"
},
"onn": {
"appName": 'com.directv.dtvlatam',
"androidName": 'com.directv.dtvlatam',
"adbLaunchCommand": "adb shell am start -n com.directv.dtvlatam/com.directvgo.feature.tv.splash.SplashActivity"
},
"xiaomi": {
"appName": 'com.directv.dtvlatam',
"androidName": 'com.directv.dtvlatam',
"adbLaunchCommand": "adb shell am start -n com.directv.dtvlatam/com.directvgo.feature.tv.splash.SplashActivity"
},
},
I'm going to merge this right now as-is, but I'll be pushing a new Firemote release fairly soon after. That way, you get credit for the pull, and multiple other devices get this shortcut too! win-win! |
v4.1.6 I hope everybody had a great holiday! I took some time away, so many of these requests are being fulfilled later than I usually complete them. I appreciate your patience as I continue to work through the backlog. Find the full launcher list here https://github.com/PRProd/HA-Firemote/wiki/Firemote-App-Launchers What's New: - Additional launchers added for skySHOWTIME (closes #577) - App Launcher for Peivo Media (closes #578) - App Launcher for Magenta Sport (closes #580) - Launcher Update for Tennis Channel US (closes #584) - App Launcher for Teleboy TV (closes #585) - App Launcher and updates for DGO (PR #587) - Launcher Update for Dropout (PR #597) Can't see these changes after updating? Visit this link: https://github.com/PRProd/HA-Firemote/wiki/Force-a-Refresh
Adds DGO launcher support for chromecast devices.
AppId = com.directv.dtvlatam