Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools 71+ causes errors building px4_msgs. Update user guide to have users install working version #3537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CJdev99
Copy link

@CJdev99 CJdev99 commented Jan 13, 2025

Update user guide to install pre setuptools 71 releases. setuptools 71+ causes the following errors building px4_msgs and px4_ros_com on fresh Ubuntu 22.04 + ROS2 Humble env:

File "/home/chase/.local/lib/python3.10/site-packages/setuptools/_core_metadata.py", line 290, in _distribution_fullname
    canonicalize_version(version, strip_trailing_zero=False),
TypeError: canonicalize_version() got an unexpected keyword argument 'strip_trailing_zero'

downgrading to setuptools==70.3.0 fixed that step for me.

@CJdev99 CJdev99 marked this pull request as ready for review January 13, 2025 03:12
@hamishwillee
Copy link
Collaborator

Can you please remove any changes other than the one in the /en branch. The toolchain automatically populates in the other branches and if I merge this the result may be a conflict.

@beniaminopozzan Is this technically OK? I am back proper on Weds and might do further investigation - hoping you know off the top of your head

…user guide to install pre setuptools 71 releases. setuptools 71+ causes the following errors building px4_msgs and px4_ros_com (en/ros2 only)
Copy link

No flaws found

@CJdev99
Copy link
Author

CJdev99 commented Jan 20, 2025

Hey @hamishwillee - updated to only update /en

@hamishwillee
Copy link
Collaborator

@CJdev99 Thanks for this. I'm waiting on @beniaminopozzan . My instinct is that it is better to see if we can get this fixed PX4/ROS side.

@beniaminopozzan
Copy link
Member

Hi @CJdev99 , is it px4_ros_com that is failing to build?
I can't replicate your issue, could you provide detailed steps please? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants