Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
Xing-lil committed Jan 23, 2025
1 parent 576efb2 commit 774f56d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -281,10 +281,8 @@ def _comms_overlap_calc(self):
# comm wait calc to finish
for idx, op in reversed(list(enumerate(block.ops))):
if is_data_parallel_reduce_op(op):
assert op.has_attr('use_calc_stream')
assert op.has_attr('ring_id')

op._set_attr('use_calc_stream', False)
ring_id = op.attr("ring_id")
block._insert_op_without_sync(
idx,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,6 @@ def get_model(self, place, batch_size, sequence_len, vocab_size):
break
assert allreduce_op_idx > 0
allreduce_op = ops[allreduce_op_idx]
assert allreduce_op.attr('use_calc_stream') is True
assert allreduce_op.dist_attr.execution_stream is not None
assert ops[allreduce_op_idx - 1].type == "nop"
assert ops[allreduce_op_idx + 1].type == "nop"

Expand Down

0 comments on commit 774f56d

Please sign in to comment.