[CINN][Backend Pass Update No.13] Update UpdateBufferAxis pass #70533
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
| AnalyzeBufferAxis analyzeBufferAxis; | ||
| analyzeBufferAxis(block); |
There was a problem hiding this comment.
这里注意遵守变量命名规范，保持buffer_axis_analyzer即可
Albresky
force-pushed
the
cinn-pass-update_buffer_axis
branch
from
8f62f90 to
04b82bf
Compare
| if (stmt->bind_info().valid()) { | ||
| var_bind_threads.insert(stmt->loop_var()->name); | ||
| StmtMutator::VisitBlock(stmt->body()); | ||
| var_bind_threads.erase(stmt->loop_var()->name); | ||
| return; |
There was a problem hiding this comment.
这里为什么不使用is_gpu_thread_binded()呢
There was a problem hiding this comment.
之前没发现Stmt的For继承了Forbase，我后面改一下
| class AnalyzeBufferAxis : public ir::IRMutator<>, | ||
| public ir::stmt::StmtMutator<> { |
There was a problem hiding this comment.
Analyze阶段使用StmtVisitor就可以了，这里没有mutate
Albresky
force-pushed
the
cinn-pass-update_buffer_axis
branch
2 times, most recently
from
5101d54 to
cad554d
Compare
Albresky
force-pushed
the
cinn-pass-update_buffer_axis
branch
from
d173a55 to
ecbd3b5
Compare
| if (stmt->bind_info().valid()) { | ||
| var_bind_threads.insert(stmt->loop_var()->name); | ||
| StmtMutator::VisitBlock(stmt->body()); | ||
| var_bind_threads.erase(stmt->loop_var()->name); | ||
| return; |
There was a problem hiding this comment.
之前没发现Stmt的For继承了Forbase，我后面改一下
| return; | ||
| } | ||
| FormalizeSingleIndex(tensor, &(store->indices)); |
There was a problem hiding this comment.
@Hongqing-work
之前的实现里面，有调用 FormalizeSingleIndex 更新 store 的 indices，我理解的是这里是应该继承 StmtMutator？
There was a problem hiding this comment.
嗯嗯，那目前还应该需要继承一下，后续IndexExpr能自动化简之后可以修改一下 @liuruyan
| if (!tensor->buffer.defined() || | ||
| tensor->buffer->memory_type == ir::MemoryType::Heap) { | ||
| ir::IRMutator<>::Visit(op, expr); |
There was a problem hiding this comment.
这里应该还是得继续Visit一下其它Expr，store的value里应该会有load
PR Category
CINN
PR Types
Improvements
Description
改造了 UpdateBufferAxis