[PIR] Delete ir parser #70534
Merged
[PIR] Delete ir parser #70534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhangbo9674
reviewed
Dec 30, 2024
paddle/common/flags.cc
Outdated
|
|
||
| PHI_DEFINE_EXPORTED_string(disable_logging_value_attr_list, | ||
| "", | ||
| "Whether to disable logging value attr in PIR."); |
paddle/common/flags.cc
Outdated
| "", | ||
| "Whether to disable logging op attr in PIR."); | ||
|
|
||
| PHI_DEFINE_EXPORTED_string(disable_logging_value_attr_list, |
There was a problem hiding this comment.
如果Op 的某个属性与 Value 的某个属性，是同一类型的属性，disable_logging_value_attr_list 会导致 op中对应属性信息也被同步删除。
除非这个 flag，最终被设计为仅仅控制 TensorDistAttr
paddle/pir/src/core/ir_printer.cc
Outdated
| @@ -360,6 +381,21 @@ void IrPrinter::PrintOperandsType(const Operation& op) { | |||
| op_operand_types.emplace_back(); | |||
| } | |||
| } | |||
| // if (!FLAGS_disable_logging_value_attr_list.empty()) { | |||
| @@ -804,7 +804,7 @@ def _parallel_pir(self, mode): | |||
|
|
|||
| # re-run apply_mix2dist_pass to dist accumulator. | |||
| apply_mix2dist_pass(dist_program) | |||
|
|
|||
| print("dist_program:", dist_program) | |||
SigureMo
previously approved these changes
Dec 31, 2024
SigureMo
previously approved these changes
Dec 31, 2024
risemeup1
force-pushed
the
delete_ir_parser
branch
from
781f53d to
e0dbfe9
Compare
XieYunshen
previously approved these changes
Dec 31, 2024
SigureMo
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Others
Description
删除ir parser相关逻辑和单测，对program打印进行了一些修改，具体包括：
pcard-67164