-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIR][OneDNN] Support Split op in bf16 (do not merge, need check ci coverage) #70857
Merged
zhanglirong1999
merged 10 commits into
PaddlePaddle:develop
from
zhanglirong1999:split_bf16_support
Jan 22, 2025
Merged
[PIR][OneDNN] Support Split op in bf16 (do not merge, need check ci coverage) #70857
zhanglirong1999
merged 10 commits into
PaddlePaddle:develop
from
zhanglirong1999:split_bf16_support
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanglirong1999
changed the title
[PIR][OneDNN] Support Split op in bf16 (do not merge, just test ci coverage)
[PIR][OneDNN] Support Split op in bf16 (do not merge, need check ci coverage)
Jan 16, 2025
zhanglirong1999
force-pushed
the
split_bf16_support
branch
from
January 17, 2025 00:59
d6f5a64
to
9971712
Compare
LLee233
reviewed
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2nd pattern should be similar.
paddle/fluid/pir/transforms/onednn/cpu_special_ops_bf16_pass.cc
Outdated
Show resolved
Hide resolved
paddle/fluid/pir/transforms/onednn/cpu_special_ops_bf16_pass.cc
Outdated
Show resolved
Hide resolved
paddle/fluid/pir/transforms/onednn/cpu_special_ops_bf16_pass.cc
Outdated
Show resolved
Hide resolved
paddle/fluid/pir/transforms/onednn/cpu_special_ops_bf16_pass.cc
Outdated
Show resolved
Hide resolved
paddle/fluid/pir/transforms/onednn/cpu_special_ops_bf16_pass.cc
Outdated
Show resolved
Hide resolved
zhanglirong1999
force-pushed
the
split_bf16_support
branch
4 times, most recently
from
January 21, 2025 12:11
9b4d533
to
7f3382e
Compare
LLee233
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Inference
PR Types
Performance
Description
Split op output is a vector, and not support bf16 q/dq in the past. We support Split op in bf16 now. We support two patterns for split op. split + builtin.split and split + builtin.slice pattern