Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dcmjs #68

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update dcmjs #68

wants to merge 2 commits into from

Conversation

alekschernof
Copy link

@PantelisGeorgiadis PantelisGeorgiadis added the enhancement New feature or request label Dec 29, 2024
@PantelisGeorgiadis
Copy link
Owner

Thank you @alekschernof for your contribution! Could you please fix the conflicts and make sure that all tests are passing?

@PantelisGeorgiadis
Copy link
Owner

@alekschernof, I tried to perform the dcmjs update and I discovered that for versions v0.34.0 and above, two of the dcmjs-dimse tests are failing, which have to do with tag consistency during round-trip file loading/saving/loading. I filed an issue here and I am tracking it.

@alekschernof
Copy link
Author

@PantelisGeorgiadis
I resolved conflicts. I am tracking this issue too. This fix and last version of dcmjs very need for me. I hope that this problem you wrote about above will be solved soon

@alekschernof
Copy link
Author

alekschernof commented Jan 14, 2025 •
edited
Loading

@PantelisGeorgiadis do you news ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PantelisGeorgiadis PantelisGeorgiadis Awaiting requested review from PantelisGeorgiadis

Assignees

@PantelisGeorgiadis PantelisGeorgiadis

@alekschernof alekschernof

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alekschernof @PantelisGeorgiadis