Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sechailer flags + cleanup a bit of gasmask code #28001

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kyunkyunkyun
Copy link
Contributor

What Does This PR Do

Moves all security swat masks under sechailer/swat.
Removes HIDEEARS flag from sechailer, allowing you to see headsets you are wearing. Swat sechailer is not touched.
Moves bane mask under mask/gas.
Changes tajaran sechailer icon a bit, so it's not hiding your hud's brightest pixel (just look how it is on images).
Gives bane and blue swat masks an actually existing item state of sechailer.
Removes repeated flags, they share them from their parent anyways.

Why It's Good For The Game

It looks better, i believe.

Images of changes

Before the changes:
image
image

After the changes:
image
image

Tajaran before the changes (looks like a mask is on his eyes literally):
image
image

After:
image
image

Testing

On local. It works as intended.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: Security gas mask won't hide your headsets anymore.
imageadd: Tajaran security gas mask was changed a bit on the sides, allowing you to see wearable hud sunglasses.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 16, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Jan 17, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants