Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom, crew-buildable vendors #28009

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FunnyMan3595
Copy link
Contributor

@FunnyMan3595 FunnyMan3595 commented Jan 17, 2025

What Does This PR Do

Adds the ability for vendors to hold actual items (rather than just typepaths), and uses it to implement a custom vendor type, which is available in the vending board and as a kit in the bar and kitchen vendors.
Migrates /obj/machinery/economy to the new attack chain.

Why It's Good For The Game

Custom vendors are not only fun for admin use, they allow chefs, cooks, and other folks with stuff to sell to do it in a standardized way.

Images of changes

2025-01-17.02-38-00.mp4

Testing

Made above video.
Disassembled a custom vendor without a linked POS.
Deconstructed and destroyed a custom vendor with stuff in it. Got the stuff back both times.
Used an ATM, merch vendor, and claw machine (all the collateral migrations).


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: Custom vendors that you can load and buy from. The chef and bartender can buy a kit from their vendor, and they can be built with a vending machine board like any other vender, but don't require a restocking kit.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally TGUI This PR modifies TGUI, will conflict labels Jan 17, 2025
@FunnyMan3595
Copy link
Contributor Author

Looks like we'll need #27784 to merge before this, since the migration on /obj/machinery/economy wasn't sufficient.

@FunnyMan3595 FunnyMan3595 added the Feature This PR is a new addition to the game label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Feature This PR is a new addition to the game TGUI This PR modifies TGUI, will conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants