Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix for a runtime error in deathsquad.dm #28012

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

Drsmail
Copy link
Contributor

@Drsmail Drsmail commented Jan 17, 2025

What Does This PR Do

Hopefully fix this runtime, from my recent PR #27663

image

Why It's Good For The Game

Bugs are bad, we kill those, especially one i introduced.

Testing

I got all channels this time. I am 99.9% sure it will now work as intended.
image
image


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
Nothing here for a players
/:cl:

@Drsmail Drsmail marked this pull request as ready for review January 17, 2025 21:55
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jan 17, 2025
Copy link
Contributor

@FunnyMan3595 FunnyMan3595 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

History is pretty messy, but that just affects the commit message on merge, so I'm OK with it, personally.

Comment on lines +51 to +53
var/obj/item/radio/borg/cyberg_radio = R.get_radio()
cyberg_radio.channels |= list("Response Team" = 1, "Special Ops" = 1)
cyberg_radio.config(cyberg_radio.channels)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var/obj/item/radio/borg/cyberg_radio = R.get_radio()
cyberg_radio.channels |= list("Response Team" = 1, "Special Ops" = 1)
cyberg_radio.config(cyberg_radio.channels)
var/obj/item/radio/borg/cyborg_radio = R.get_radio()
cyborg_radio.channels |= list("Response Team" = 1, "Special Ops" = 1)
cyborg_radio.config(cyborg_radio.channels)

Just a small typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting type assignment This PR is waiting for its type to be assigned internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants