-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Fix for a runtime error in deathsquad.dm #28012
Open
Drsmail
wants to merge
17
commits into
ParadiseSS13:master
Choose a base branch
from
Drsmail:Deathsquad_ai_laws
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+5
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks Christasmurf Co-authored-by: Christasmurf <[email protected]> Signed-off-by: Drsmail <[email protected]>
Signed-off-by: Drsmail <[email protected]>
…ise-SS220 into Deathsquad_ai_laws. Because my setting is realy bad and i can't pull changes from PR. Probably i will brake everything.
Co-authored-by: Burzah <[email protected]> Signed-off-by: Drsmail <[email protected]>
…ise-SS220 into Deathsquad_ai_laws
Signed-off-by: Drsmail <[email protected]>
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
label
Jan 17, 2025
FunnyMan3595
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
History is pretty messy, but that just affects the commit message on merge, so I'm OK with it, personally.
MiraHell
reviewed
Jan 17, 2025
Comment on lines
+51
to
+53
var/obj/item/radio/borg/cyberg_radio = R.get_radio() | ||
cyberg_radio.channels |= list("Response Team" = 1, "Special Ops" = 1) | ||
cyberg_radio.config(cyberg_radio.channels) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
var/obj/item/radio/borg/cyberg_radio = R.get_radio() | |
cyberg_radio.channels |= list("Response Team" = 1, "Special Ops" = 1) | |
cyberg_radio.config(cyberg_radio.channels) | |
var/obj/item/radio/borg/cyborg_radio = R.get_radio() | |
cyborg_radio.channels |= list("Response Team" = 1, "Special Ops" = 1) | |
cyborg_radio.config(cyborg_radio.channels) |
Just a small typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Hopefully fix this runtime, from my recent PR #27663
Why It's Good For The Game
Bugs are bad, we kill those, especially one i introduced.
Testing
I got all channels this time. I am 99.9% sure it will now work as intended.
Declaration
Changelog
🆑
Nothing here for a players
/:cl: