Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warcries used Recently and Stunned Recently value should default to 1 when flag set #573

Open
1 task done
Blitz54 opened this issue Jan 24, 2025 · 0 comments · May be fixed by #637
Open
1 task done

Warcries used Recently and Stunned Recently value should default to 1 when flag set #573

Blitz54 opened this issue Jan 24, 2025 · 0 comments · May be fixed by #637
Labels
enhancement New feature, calculation, or mod

Comments

@Blitz54
Copy link
Contributor

Blitz54 commented Jan 24, 2025

Check for duplicates

  • I've checked for duplicate open and closed issues by using the search function of the issue tracker

What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

Was looking into "Briny Carapace" which increases stun threshold based on the # of times you were stunned recently, and while I did get it working, I think it could be better. I followed the same structure of "# of Warcries used recently" and my issue is that setting the checkbox for "used a warcry recently" only sets the flag, but I think it should also set the # used to 1 as default, as it would be guaranteed you have used at least 1. This was more noticeable when I added "# stunned recently" because of the two small passive nodes before Briny Carapace, because they would lower your threshold by 40%, but the 60% increase wouldn't activate unless you manually entered a value into the box.

Warcry does the same, it sets the flag, but there is no DPS increase when using "Deafening Cries" unless you manually enter a value.

Both have the issue of unchecking the flag box but leaving a value in the text box.

Describe the solution you'd like

The "# of warcries used recently" and "# of times stunned recently" (when implemented) should default to 1 if the checkbox is ticked. I think it should also prevent the user from entering a value less than 1 if the checkbox is enabled. This would be much more user friendly for people new to PoB.

That, or remove the checkbox and have just the value box for setting the flag, but I think that is also unintuitive for the average user.

Describe alternatives you've considered

Currently you can just set the value box to whatever number you need.

Additional context

Image

@Blitz54 Blitz54 added the enhancement New feature, calculation, or mod label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant