Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Times Stunned Recently and edited Warcries used Recently #637

Merged

Conversation

Blitz54
Copy link
Contributor

@Blitz54 Blitz54 commented Jan 27, 2025

Fixes #573

Description of the problem being solved:

Number of times Stunned Recently implemented. Briny Carapace uses this, and Quick Recovery probably does? I assume it stacks, I haven't touched that anyway yet. Also changed warcries used recently to clean up config.

EDIT: ooooooh cant use the # sign at the start of a sentence, thats why my text was all wonky.

Short form

  • Times Stunned Recently is hidden unless Stunned Recently is toggled on
  • Same for # Warcries used Recently
  • The default value in each number box is 1, it is guaranteed the player used at least 1 warcry if toggled
  • This also fixes the issue of toggling warcries, but not having any damage increase from "Deafening Cries" unless you manually enter a value into the box.
  • When unchecking "Stunned Recently", the # times box will go red, and the values inside the box are not calculated as we check for the status of the toggle box.
  • Same for # of Warcries, before if you left a number in the box but turned off the toggle, you would still get the dps.

Please check it over, I think you will like

Steps taken to verify a working solution:

Link to a build that showcases this PR:

Before screenshot:

After screenshot:

image
image

@Blitz54
Copy link
Contributor Author

Blitz54 commented Jan 27, 2025

Also just checked, but should we add "Hit Recently" to Stunned recently? Keep both boxes of course, because there are times you are hit but not stunned. But if we got stunned, we were clearly hit.

@LocalIdentity LocalIdentity merged commit 2aa9799 into PathOfBuildingCommunity:dev Jan 29, 2025
2 checks passed
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Jan 29, 2025
@Blitz54 Blitz54 deleted the times-stunned-recent branch January 29, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warcries used Recently and Stunned Recently value should default to 1 when flag set
2 participants