Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Necromantic Talisman in skill tree not working properly. #623

Open
2 tasks done
silverbackllama opened this issue Jan 26, 2025 · 2 comments · May be fixed by #645
Open
2 tasks done

Necromantic Talisman in skill tree not working properly. #623

silverbackllama opened this issue Jan 26, 2025 · 2 comments · May be fixed by #645
Labels
enhancement New feature, calculation, or mod good first issue Good for newcomers

Comments

@silverbackllama
Copy link

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate open and closed issues by using the search function of the issue tracker

What platform are you running Path of Building on?

Windows

How is Path of Building expected to behave?

The passive skill is not displaying the correct values in POB. It shows the equipped amulet's stats as a benefit to the character rather than to the minions.

How does Path of Building behave?

The stat modifiers are wrong.

How to reproduce the issue

No response

Character build code

Screenshots

No response

@silverbackllama silverbackllama added the bug Something isn't working label Jan 26, 2025
@Wires77 Wires77 transferred this issue from PathOfBuildingCommunity/PathOfBuilding Jan 26, 2025
@QuickStick123 QuickStick123 added enhancement New feature, calculation, or mod and removed bug Something isn't working labels Jan 27, 2025
@Peechey
Copy link
Contributor

Peechey commented Jan 27, 2025

Dev notes
We have logic for Necromantic Aegis from PoE1 which is for shields rather than amulets. We could pretty easily switch out a few words and have it work, but it would be nice for the logic to not hardcode the keystone's ID and name. Unsure if it's possible without doing so, though.

@QuickStick123 QuickStick123 added the good first issue Good for newcomers label Jan 28, 2025
@majochem
Copy link

I'd like to take a stab at this one. Maybe hardcoded solution first (already got that working), then look into a more "flexible" option after.

@majochem majochem linked a pull request Jan 28, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants