Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Necromantic Talisman #645

Merged

Conversation

majochem
Copy link
Contributor

@majochem majochem commented Jan 28, 2025

Fixes #623 .

Description of the problem being solved:

  • Adds support for "Necromantic Talisman" keystone
  • Removes some of the obsolete logic for PoE1 keystone "Necromantic Aegis"

Steps taken to verify a working solution:

  • Check that amulet mods no longer apply to player
  • Check that amulet mods apply to minions instead
  • Check that "Anoints" do not modify minion stats (this was already the case, just wanted to make sure)
  • Check that mod text is recognized and appears as "blue" on the passive tree

Link to a build that showcases this PR:

Build

Before screenshot:

image

After screenshot:

image

@majochem
Copy link
Contributor Author

the additional changes in modCache to the fire, cold, and lightning resistance mods were not caused by my change to modParser . They also happen when I just recreate modCache without any changes at all.

@majochem majochem marked this pull request as ready for review January 29, 2025 07:42
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Jan 29, 2025
@LocalIdentity LocalIdentity merged commit 64e4e4e into PathOfBuildingCommunity:dev Jan 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Necromantic Talisman in skill tree not working properly.
2 participants