Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite scaling and stat mod line conversion to export more stuff #173

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

QuickStick123
Copy link
Contributor

@QuickStick123 QuickStick123 commented Jan 17, 2025

Description of the problem being solved:

To properly get all the stat data from a modLine e.g. order, tradeId, etc we have to go through the statDescriptors and stats. This produces the correct tradeId (regardless if they exist). It can be thought of as an inverse to the current statDescriptor stuff but including other details related to the stats. It also makes a best guess at the values of modLine's stats that don't exist e.g. Always Poison gets assumed to have a stat value of 100 this means it can be used to be scaled now. This also exports all forms of a given modLine and if a given stat is local which will be useful for trade.

Example

	["Adds # to # Cold Damage while affected by Hatred"] = {
		{ "minimum_added_cold_damage_while_affected_by_hatred", "maximum_added_cold_damage_while_affected_by_hatred", subsituions = { 1, 2 }, order = 7853, tradeHash = 2643562209, isLocal = { false, false }, isScalable = { true, true }, },
	},
	["Adds # to # Cold Damage while you have Avian's Might"] = {
		{ "minimum_added_cold_damage_while_you_have_avians_might", "maximum_added_cold_damage_while_you_have_avians_might", subsituions = { 1, 2 }, order = 7854, tradeHash = 3485231932, isLocal = { false, false }, isScalable = { true, true }, },
	},
	["Adds # to # Cold damage to Attacks"] = {
		{ "attack_minimum_added_cold_damage", "attack_maximum_added_cold_damage", subsituions = { 1, 2 }, order = 846, tradeHash = 4067062424, isLocal = { false, false }, isScalable = { true, true }, },
	},
	["Adds # to # Fire Attack Damage per Buff on you"] = {
		{ "minimum_added_fire_attack_damage_per_active_buff", "maximum_added_fire_attack_damage_per_active_buff", subsituions = { 1, 2 }, order = 1152, tradeHash = 761505024, isLocal = { false, false }, isScalable = { true, true }, },
	},
	["Adds # to # Fire Damage"] = {
		{ "local_minimum_added_fire_damage", "local_maximum_added_fire_damage", subsituions = { 1, 2 }, order = 824, tradeHash = 709508406, isLocal = { true, true }, isScalable = { true, true }, },
		{ "global_minimum_added_fire_damage", "global_maximum_added_fire_damage", subsituions = { 1, 2 }, order = 1208, tradeHash = 321077055, isLocal = { false, false }, isScalable = { true, true }, },
	},
	["Adds # to # Fire Damage against Ignited Enemies"] = {
		{ "global_minimum_added_fire_damage_vs_ignited_enemies", "global_maximum_added_fire_damage_vs_ignited_enemies", subsituions = { 1, 2 }, order = 6119, tradeHash = 794830148, isLocal = { false, false }, isScalable = { true, true }, },
	},
	["Adds # to # Fire Damage if you've Blocked Recently"] = {
		{ "minimum_added_fire_damage_if_blocked_recently", "maximum_added_fire_damage_if_blocked_recently", subsituions = { 1, 2 }, order = 3867, tradeHash = 3623716321, isLocal = { false, false }, isScalable = { true, true }, },
	},
	["Adds # to # Fire Damage if you've Killed Recently"] = {
		{ "enchantment_boots_minimum_added_fire_damage_on_kill_4s", "enchantment_boots_maximum_added_fire_damage_on_kill_4s", subsituions = { 1, 2 }, order = 2871, tradeHash = 3077703716, isLocal = { false, false }, isScalable = { true, true }, },
	},
	["Adds # to # Fire Damage if you've dealt a Critical Hit Recently"] = {
		{ "minimum_added_fire_damage_if_have_crit_recently", "maximum_added_fire_damage_if_have_crit_recently", subsituions = { 1, 2 }, order = 7855, tradeHash = 3144358296, isLocal = { false, false }, isScalable = { true, true }, },
	},

Todo

  • Fix scaling stuff to use new stuff
  • Figure out radius jewel mods?

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Jan 17, 2025
@QuickStick123 QuickStick123 force-pushed the rewrite-scaling-and-stat-modLine-conversion branch from 06f9291 to 0b81e0e Compare January 17, 2025 03:03
@QuickStick123 QuickStick123 marked this pull request as draft January 19, 2025 11:03
@QuickStick123 QuickStick123 changed the title [WIP] Rewrite scaling and stat mod line conversion to export more stuff Rewrite scaling and stat mod line conversion to export more stuff Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant