Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Threaded Light Woven Focus Spirit mod #595

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

PGDeve
Copy link
Contributor

@PGDeve PGDeve commented Jan 24, 2025

Fixes #544 .

Description of the problem being solved:

Add Threaded Light Woven Focus spell dmg per 10 spirit request.
Also added "per (%d+) spirit" for future reference.

Steps taken to verify a working solution:

  • Tested on POB2
  • Automatic tests successful

Link to a build that showcases this PR:

https://pobb.in/6NwRXbHnSHEh

After screenshot:

no
on_spark
off_boneshatter
on_boneshatter

@PGDeve PGDeve changed the title Add Threaded Light Woven Focus spell dmg per 10 spirit request Add Threaded Light Woven Focus spell dmg per 10 spirit Jan 24, 2025
The point of having the `["per (%d+) spirit"]` is so that you don't need to write out the full mod and PoB will instead piece it together
Also the way you had it before, the number was being treated as a string instead of a int
Copy link
Contributor

@LocalIdentity LocalIdentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to make a small fix to the PR, have a look at the commit comment for why I made it

@LocalIdentity LocalIdentity merged commit 842b585 into PathOfBuildingCommunity:dev Jan 27, 2025
2 checks passed
@LocalIdentity LocalIdentity changed the title Add Threaded Light Woven Focus spell dmg per 10 spirit Add support for Threaded Light Woven Focus Spirit mod Jan 27, 2025
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Threaded Light Woven Focus spell dmg per 10 spirit request
2 participants