Add support for Inevitable Critical Support #603
Conversation
|
EDIT: Cleaner way to do it, still might be a better way but I think this is good.
|
There was a problem hiding this comment.
You should use limitTotal. It makes the limit apply to the total value after multiplication.
I'm not convicted by this implementation. Do we really expect users to figure out if they crit 2 or 3 seconds ago?
In my opinion a checkbox would be a better solution. At least until someone good enough at maths figures out how to calculate the effective impact.
src/Data/Skills/sup_int.lua
Outdated
| @@ -2060,6 +2060,14 @@ skills["SupportInevitableCriticalsPlayer"] = { | |||
| label = "Inevitable Critical", | |||
| incrementalEffectiveness = 0.092720001935959, | |||
| statDescriptionScope = "gem_stat_descriptions", | |||
| statMap = { | |||
| ["support_inevitable_criticals_critical_strike_chance_+%_per_second"] = { | |||
| mod("CritChance", "INC", nil, 0, 0, { type = "Multiplier", var = "SecondsSinceInevitableCrit", limitVar = "InevitableCritCap" }), | |||
There was a problem hiding this comment.
| mod("CritChance", "INC", nil, 0, 0, { type = "Multiplier", var = "SecondsSinceInevitableCrit", limitVar = "InevitableCritCap" }), | |
| mod("CritChance", "INC", nil, 0, 0, { type = "Multiplier", var = "SecondsSinceInevitableCrit", limitVar = "InevitableCritCap", limitTotal = true }), |
src/Export/Skills/sup_int.txt
Outdated
| @@ -543,6 +543,14 @@ statMap = { | |||
| #skill SupportInevitableCriticalsPlayer | |||
| #startSets | |||
| #set SupportInevitableCriticalsPlayer | |||
| statMap = { | |||
| ["support_inevitable_criticals_critical_strike_chance_+%_per_second"] = { | |||
| mod("CritChance", "INC", nil, 0, 0, { type = "Multiplier", var = "SecondsSinceInevitableCrit", limitVar = "InevitableCritCap" }), | |||
There was a problem hiding this comment.
| mod("CritChance", "INC", nil, 0, 0, { type = "Multiplier", var = "SecondsSinceInevitableCrit", limitVar = "InevitableCritCap" }), | |
| mod("CritChance", "INC", nil, 0, 0, { type = "Multiplier", var = "SecondsSinceInevitableCrit", limitVar = "InevitableCritCap", limitTotal = true }), |
@PJacek thanks! limitTotal makes sense. Regarding the checkbox vs number I can only speak for myself as a monk but I would prefer the ability to see just how much my crit chance is affected by the second. For example, I have it on Falling Thunder, and when I throw down a fully "charged" attack at 4 seconds I know it'll always crit, but I also get power charges back from that hit, so I could immediately Falling Thunder again, and would be nice to know what my crit chance is, say 1-2 seconds after my last hit, or if I should just wait a bit to get it fully charged again. Idk, given that PoB is all about customization and nitty-gritty stuff this seems to be in line with the general philosophy to err on the side of giving users more control rather than abstracting functionality. Thoughts? |
LocalIdentity
changed the title
Fixes #298
Description of the problem being solved:
Link to a build that showcases this PR: https://maxroll.gg/poe2/pob/vjqam0y9
Before screenshot:
After screenshot: