Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Heroic Tragedy Timeless Jewel Keystones #621

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Peechey
Copy link
Contributor

@Peechey Peechey commented Jan 26, 2025

Description of the problem being solved:

Supports Heroic Tragedy and ideally any other Keystone changing timeless jewel given we have the LegionPassive data for it. Normal and Notable legion code is commented out for now, these require seed data. I did have to locally tweak the script so it would default a statOrder for the "dummy_stat" fields in the dat file. If wanted, I could rip everything out of there except the "kalguur" stuff.

Does not update icon/sprite, not sure if we have the image

Steps taken to verify a working solution:

  • Made a loadout for each time of Heroic Tragedy, check calcs

Link to a build that showcases this PR:

eNrlW-F34jYS_7z5K_z4dPeOJLaBQPJI-0hINvRIwgLZbT_tU2wBamSLs-UktK__-40k2xgWGTnpXfvafthia36jmdFoNDNyut-_BtR6xlFMWHhec47smoVDj_kknJ_XHqbXh53a998ddEeIL-5nFwmhYsT97uBDVz5YFD9jCkC3ZnkUxfEdCvB5bYzCOY5qFoo9HPqX64E7FuKaxVE0x_xzNqv91QH0AkXI4zgaCo69hLNb5gNihmgMkACRcMK8J8w_RixZwow165ngF0U0uB3dj6c1EOtDd0TRCkcTjrgVwz_ntR6oh-a4jwL4F1CIJgCxj-yTZu24FHKRRDGvgpssMfZzUufI1RGOInw1m2GPk2d8GRF-uUChV5hEh6tKe5tQTpaUiMVI6bUy3XzD2jnR0U4ZR7Q_mhTN0j7plJMzvl_oL4QvLihY0Zy5gAzmIeG4GmbESMzC6kpsILTGTyiFnWJEO8Yxjp4RJ1vSaHmz4JGEVUx0i0J0yWID-wvKEY5g2_JKgAn2GOz0qnNURA7JDJtTVtIjBVSV5m16XE1M6SozfptAYwhxZpQTllBDSr4OOidtHVUfv67jTUtHNQjXE5awemZiE-0XTW7lq5tRYebG0Wm73Wq1Oi2npd1Ho8UqJh6it-iVBEkAEXOKnvB6wkbjRO8s8wUPISTosG5De6xckwi_AXbJqP8W2AKxWIs7cfTbmoQ3KPR7npfAUb5aG9fulG2hNd1p2cHqnQniQejl9KVcH8JIhtXieaznLxBj2C_i3H-k2BSyniTddgWd7fK55jhMJ1yZRZohxt7iI9h4jDg2C7I51albalhBWzRsKdMdhtWz3wRUMJIA7jZS46hdBqpopsmSQJpkIpGi3OVW5pgKBrgKcTRfTRYE08JUjYYJfWazS7Q0gUofKOKLvmA6YyV_LkIrLpg4qarO9ozi4rHgtE_LTaHozXYEhmQVAD42TctHEftZJP60GqwXBSyJzJwOdFDkRipkh5oqdMbYT7yNU1Qb8PMK5oJCZWaqSI4COSmtBO1xjrynPvPnxmaTk1RCbMo3SZZL2L3CH0wZiNMaUnpSyJEOmwbU9-DNxR1rl53r5hOsqY0nyHMV81m2IOa6iGRjaxoTYuMJ8uW8hWgRQPCVNfot8_f79zXUcEYFmSQ0LAxH7AUkX4gOSFyNGlKydVTWihLh8JeVMf8NcqMJrkIfsjvYCMZzbCN2TXORzGax5UFhi_gQlve8VrMe4V32GzLKGKcPCjElAYTeOO4jjiw_zfw_o4igkLuyPRRjFHkLAbpGlD5C5BCc1m_lk2wpXRPKcdSHd0JMoco2Rydzk-6x7HuJX4NgySJu4VfxvxGK-CrrVklC-Qb4xJyEsraH-EVpzZos2EvPfxYzTRmjcd7iQsslDv0NHtMIYwtl0cgTQkjlxYMVoBikXikHj4U2nHCKZeGFwzlfWIeH1mcWyUSw0Ikb-FLDkIFs57Vmp2k7dcdp2vWW3Wydws-O26o34G2r7jRd96R-YrcbrbrbsVt2vdE6FeSNjtupnzgNx627DozUW83TTrPutFp2u-423U67ftLodDrC3qIKRdGqtylBSMAWICjeagOuJRSafug-jIfyx4cF58v47Pj45eXlaIn4gs3wKxyiR-A0x0sAgY0O4ydC6aHgetyD_y7mvV6_bY8vbj4ltz9NZ3etIR-57uTnvu1e3B_2Hlb9L6v-avoj_9p6Ano54XE2Y1f1G2M1ffokzSbkk0apWYTjQDymQQTgRVRXhKmIgKFTJnCCReQx4TgbAAd5vVMrAcxCnv-OeXT3zQop-6oVUlZWq6JWQq2ZWgm1Kmq11Epk8m2IBOKCKxn4FJTpMEDAo8GpbrEvE-CqTiUFSZ2qKL4StuhUyuWUKqnLSdWlin8ip5oFn-5aP-AGONXDqiedqj39-mU1eDkd_XB_1Xh5l1O573cqnfNIixedR61N6jxybZTdU4vvds13OtUg5JBiEUjmPSz86p5GjC-q-JXyk6JfpSHIIFgpLQvh7s_iV1M--ir8atB52g5W1-3Z8OeP7_Wrxu8brIx9rBig1NpsHhWmftU9Fgej-HHHuBoTL7OH7kRYNobDPeIfcRBfrCAzuxa15lbvPD1ZBfUEc5U0FDHnNR4lWCQDM5RQ8f5TgigRB71dfDtUl2Ahi4K8Nwis4KAX5YPiOF0thWa94TA9wtNZLeKvcwsluPh5iainlB6EywRWUl6fBST2voq8SFx7SYPJe7qr6-ury-ng81WaGxUh0su-hknwKO6A1P_XOe8Ey1rPipPHWP08r30m-EUK0sccEQoZnscoRcsY58mJFDrVgAKuhJukuiH5NdpuXmsCPaerVxxBLjX_AglcRLBWrnx8j1BqQtFDELmkjpu4tdIzUhXpJQQ41b3QWEpeC-q5iJs6rTpisAQLWSii2pnT0T2W4MI3YWuRGfFE4l6-5MKTFVWJXfIesHa903Jaz0NeA-oYqEE9WF3u6dDpaIlV5X2i1qpqVA_vYw9pdVeDenDeEGPhjWhN7uaSU5VwumOhdHLYND1CRfGrXdkrinMSPcN7vsBReo7rON1CjMpISjeOOlu0fAoUJbaS9wcaC4kxPVQ1yDU6iLGSTZM2jXW7nZRv2c3WrmY9ijR6VqoZorVh2lgpWYa0q6hZAjVaoknWWdUokQ6XbBQZg3vPjPiquabZMltkZUEDMpr3s5Edw_ez2W4hvp_jNaScT9r1Tkf18AdORP6yg4vKdIyYiI31Pg5if72Pg-glBW9Gj7dTkTV2XJ6E5F2vneBstGzvp82wN3NQLbs3w2VH8c1oeQD08UxUbKUnQE5Tsjl4EvbBGLxkYxiykmLtjiJr7SrxUmfhTk0rc1S7O71HLwsAimQPIzjMb0rSRTNOeVf8BiMqPoVi9H0Mv_le4D3MxNVeskShn7G735Wkr9fB0HqMx8BT9m_74gbxvTYMcbDawUgvV_c4K-tkZ1cUWmk_esIjUVP_wljw03nt8KTjHnVajWbDdk7c05YaSKtMx05LS0jB-wTWMZL-l80rKH8EFo7bPD1qtzttu-N02urKvDvgUNqmZa_4nVe9en5JjNWHRF8wWrJQIpSpVKkJXKxn1SSXrFQ5K8v3MRINwzPr4W7w6eHq4AZHjHjWVHxZ6a8Osga-9QN-wfQgbbSfpR3r9bNqNq6fVZPoQBWe2LfyAedgjHySxMACRytrKGLZwZAERFBxJgigHKLEg91zZtkHv6Zinzm__RqJD1bP7KPWb2Mc4OBRhGjYaNY_HNs-7Ni2_U8LCob5C9TyC9HUx35sPa4sCBUWJSG22CyTO-fq_i5cU-1zro3fhWtqw5HqRMUWCa1I2s5CEbYuWfifBNzAz2D_RnSeJNHBDSSTLCKe7M3cMl9-5mtJecQXiK1aoZlRRuHupWjspWjupcg-JjsWPrrDWd1MmD_CWd2_l7P-BV31_-eojWyqP8JRG38rR3X-eo7q_K8dVTSx9VlCMSHoTijj8hZi9PgwHoqMRzWpP1L2LLLs7ILCzkTRAdQ0llMBIovCSohekFDMKwBkUWo1KiOqq-FWt1UVyAWmO_WWt0UDH2i3r5YUTgYdq3DblPE1XE5r8iK-6TGWcyz2aCXFmL-ysqZXZQu-STynsjtUUegGQ6HKK1mA8W93mtrSsG3VtzUQuGA_i8LkCxYfdsWqepHlg7ydYuGMzNNCQj2kpYTE52_WXw_Iq7LNYFC8pfISiIIBBJ54fav1L4i9FpZ9UChQRCP0QL5CcvnUb6w6jJboIoTzTPcRRR5eMOrjKOWPRa2W_nVWdgfWtu09gI2P0zLYPlD-JVx245Xfudmuu2_Cwp93ZbDWHkzxc8Mcs1czePMG-cRcb4DJynWN6DT19EH-B2viT7TEgTmRN2wsCTkkJ7PCvC0DHSsbJl-9kWhiZLCGKar6QggX2zZp0z7dA8sb77lNy4wqIZuf-VZ2SwGFOPgUQnIplyRes3BN3M3UoJMFnDLbMzgl9B6TDRRjgJQo_diZUSpTnWJU2IPMTo98JrdzahsYcNvujRJQTOaE3s9krxY0kw1nU83EHjW19eVCXOHvNl33OA_jqnUln7476B5_88fA_wUqjDBL

Before screenshot:

image

After screenshot:

image
image
image

@Peechey Peechey added the enhancement New feature, calculation, or mod label Jan 26, 2025
@LocalIdentity LocalIdentity changed the title Add support for Heroic Tragedy Timeless Jewel Add support for Heroic Tragedy Timeless Jewel Keystones Jan 27, 2025
@OrderedSet86
Copy link
Contributor

How does it handle Gemling? Apparently Gemling does not double Timeless Jewel Keystones: https://www.reddit.com/r/PathOfExile2/comments/1hr722x/to_save_anyone_else_the_pain_the_new_timeless/

@Peechey
Copy link
Contributor Author

Peechey commented Jan 27, 2025

It shouldn't double it, because the mod is created directly from the node and not in the calculations where we do the "double inherent" attribute logic. If that is in fact a bug, won't be too hard to update for.

EDIT: It does not double

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants