Add support for Glancing Blows and Stand Ground #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Jan 27, 2025
LocalIdentity
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
Removed old PoE1 code for Glancing Blows keystone, as block chance now applies to both hits and spells in PoE2. Then parsed the new wording for the keystone.
I also removed the "Spell Block Chance" in the calcs page because it is no longer needed and shows 0 all the time. The actual calculations are still done but I don't want to break things.
Also added "while affected by any damaging ailment" that checks if the player is ignited, poisoned, or bleeding.
Steps taken to verify a working solution:
-Checked calc for block chance, it does double and is still properly capped to 75.
-Enabled all combinations of player ignited, poisoned, and bleeding in the config. Life regen increased when any one of them is true.
Link to a build that showcases this PR:
Before screenshot:
After screenshot: