Add support for Dance with Death and Charm mods #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
-Added support for Dance with Death. It checks for empty offhand, and a one handed weapon.
-Added config for using charm, and made "Lucky Rabbit Foot" work.
-"increased effect of charms applied to you", "flask and charm charges gained", and "while you have an active charm" were added. Some nodes that used this were "Lucky Rabbit Foot" and "Efficient Alchemy"
Steps taken to verify a working solution:
-Tested Dance with Death with equipment pairs to ensure it worked as expected. Equipping anything in slot 2 is recognized as failing the check. Using a two hand melee fails. Using a bow with slot 2 open fails. Using a wand with slot 2 open fails. Using a mace and an empty slot 2 passes as the node activates.
-Resistance from Charm increased with charm effect. I copied the flask code, so it should only work on the player. They may allow charms to affect minions later, and it says "applied to you".
Link to a build that showcases this PR:
Before screenshot:
After screenshot: