Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new property in case of images' width are smaller than window's screen #74

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

ksairi
Copy link
Contributor

@ksairi ksairi commented Sep 19, 2018

#73

@ksairi ksairi force-pushed the master branch 2 times, most recently from d746e99 to 2e8285b Compare September 19, 2018 10:16
@johhansantana
Copy link

how would you get the width of the image and pass it as a prop? I'm wondering if this could be made automatically.

@ksairi
Copy link
Contributor Author

ksairi commented Sep 27, 2019

how would you get the width of the image and pass it as a prop? I'm wondering if this could be made automatically.

If you are dealing with images that you know, e.g in your asset folder, you know the width. If you are dealing with remote images, that could be read from the metadata of the response

@alex-shul
Copy link

Excellent solution! It works! Why this is not commited to a master branch? Is project alive?

@ArtiomShapovalov ArtiomShapovalov merged commit ead160a into PaulBGD:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants