feat: Deprecate php 5.6 and 7.0

.circleci/config.yml

@@ -24,54 +24,6 @@ tests_with_future_mode: &tests_with_future_mode
       vendor/bin/php-cs-fixer fix --diff || (echo "Coding standards are not respected. Run 'vendor/bin/php-cs-fixer fix'" && exit 1)
 
 jobs:
-  php 5.6:
-    docker:
-      - image: circleci/php:5.6
-    steps:
-      - checkout
-      - <<: *composer
-      - <<: *tests
-
-  php 5.6 with future mode:
-    docker:
-      - image: circleci/php:5.6
-    steps:
-      - checkout
-      - <<: *composer
-      - <<: *tests
-
-  php 5.6 with lowest dependencies:
-    docker:
-      - image: circleci/php:5.6
-    steps:
-      - checkout
-      - <<: *composer_with_lowest_dependencies
-      - <<: *tests
-
-  php 7.0:
-    docker:
-      - image: circleci/php:7.0
-    steps:
-      - checkout
-      - <<: *composer
-      - <<: *tests
-
-  php 7.0 with future mode:
-    docker:
-      - image: circleci/php:7.0
-    steps:
-      - checkout
-      - <<: *composer
-      - <<: *tests_with_future_mode
-
-  php 7.0 with lowest dependencies:
-    docker:
-      - image: circleci/php:7.0
-    steps:
-      - checkout
-      - <<: *composer_with_lowest_dependencies
-      - <<: *tests
-
   php 7.1:
     docker:
       - image: circleci/php:7.1
@@ -166,20 +118,6 @@ workflows:
   PR:
     jobs:
       - documentation is up to date
-      - php 5.6
-      - php 5.6 with future mode:
-          requires:
-            - php 5.6
-      - php 5.6 with lowest dependencies:
-          requires:
-            - php 5.6
-      - php 7.0
-      - php 7.0 with future mode:
-          requires:
-            - php 7.0
-      - php 7.0 with lowest dependencies:
-          requires:
-            - php 7.0
       - php 7.1
       - php 7.1 with future mode:
           requires:
@@ -204,12 +142,6 @@ workflows:
       - release:
           requires:
             - documentation is up to date
-            - php 5.6
-            - php 5.6 with future mode
-            - php 5.6 with lowest dependencies
-            - php 7.0
-            - php 7.0 with future mode
-            - php 7.0 with lowest dependencies
             - php 7.1
             - php 7.1 with future mode
             - php 7.1 with lowest dependencies

.php_cs.dist

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use PedroTroller\CS\Fixer\Fixers;
 use PedroTroller\CS\Fixer\RuleSetFactory;
 
@@ -8,7 +10,7 @@ return PhpCsFixer\Config::create()
     ->setRules(
         RuleSetFactory::create()
             ->phpCsFixer(true)
-            ->php(5.6, true)
+            ->php(7.1, true)
             ->pedrotroller(true)
             ->enable('ordered_imports')
             ->enable('align_multiline_comment')

composer.json

@@ -3,7 +3,7 @@
     "description": "PHP-CS-FIXER : my custom fixers",
     "license": "MIT",
     "require": {
-        "php": ">=5.6",
+        "php": ">=7.1",
         "friendsofphp/php-cs-fixer": "^2.14.2"
     },
     "require-dev": {

spec/PedroTroller/CS/Fixer/RuleSetFactorySpec.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\PedroTroller\CS\Fixer;
 
 use PedroTroller\CS\Fixer\Fixers;

src/PedroTroller/CS/Fixer/AbstractFixer.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace PedroTroller\CS\Fixer;
 
 use PhpCsFixer\AbstractFixer as PhpCsFixer;

src/PedroTroller/CS/Fixer/AbstractOrderedClassElementsFixer.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace PedroTroller\CS\Fixer;
 
 use PhpCsFixer\Tokenizer\CT;
@@ -11,7 +13,7 @@ abstract class AbstractOrderedClassElementsFixer extends AbstractFixer
     /**
      * {@inheritdoc}
      */
-    protected function applyFix(SplFileInfo $file, Tokens $tokens)
+    protected function applyFix(SplFileInfo $file, Tokens $tokens): void
     {
         for ($i = 1, $count = $tokens->count(); $i < $count; ++$i) {
             if (!$tokens[$i]->isClassy()) {
@@ -187,7 +189,7 @@ private function sortTokens(
         $startIndex,
         $endIndex,
         array $elements
-    ) {
+    ): void {
         $replaceTokens = [];
 
         foreach ($elements as $element) {

src/PedroTroller/CS/Fixer/ClassNotation/OrderedWithGetterAndSetterFirstFixer.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace PedroTroller\CS\Fixer\ClassNotation;
 
 use PedroTroller\CS\Fixer\AbstractOrderedClassElementsFixer;

src/PedroTroller/CS/Fixer/CodingStyle/ExceptionsPunctuationFixer.php

@@ -59,7 +59,7 @@ public function getDocumentation()
         return 'Exception messages MUST ends by ".", "…", "?" or "!".<br /><br /><i>Risky: will change the exception message.</i>';
     }
 
-    protected function applyFix(SplFileInfo $file, Tokens $tokens)
+    protected function applyFix(SplFileInfo $file, Tokens $tokens): void
     {
         $cases = $this->analyze($tokens)->findAllSequences([
             [

src/PedroTroller/CS/Fixer/CodingStyle/ForbiddenFunctionsFixer.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace PedroTroller\CS\Fixer\CodingStyle;
 
 use PedroTroller\CS\Fixer\AbstractFixer;
@@ -59,7 +61,7 @@ public function getDocumentation()
         return 'Forbidden functions MUST BE commented';
     }
 
-    protected function applyFix(SplFileInfo $file, Tokens $tokens)
+    protected function applyFix(SplFileInfo $file, Tokens $tokens): void
     {
         $calls = [];
 

src/PedroTroller/CS/Fixer/CodingStyle/LineBreakBetweenMethodArgumentsFixer.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace PedroTroller\CS\Fixer\CodingStyle;
 
 use PedroTroller\CS\Fixer\AbstractFixer;
@@ -82,7 +84,7 @@ public function fun3(
     /**
      * {@inheritdoc}
      */
-    protected function applyFix(SplFileInfo $file, Tokens $tokens)
+    protected function applyFix(SplFileInfo $file, Tokens $tokens): void
     {
         $functions = [];
 
@@ -158,7 +160,7 @@ protected function createConfigurationDefinition()
         ]);
     }
 
-    private function splitArgs(Tokens $tokens, $index)
+    private function splitArgs(Tokens $tokens, $index): void
     {
         $openBraceIndex  = $tokens->getNextTokenOfKind($index, ['(']);
         $closeBraceIndex = $this->analyze($tokens)->getClosingParenthesis($openBraceIndex);
@@ -220,7 +222,7 @@ private function splitArgs(Tokens $tokens, $index)
         $tokens->removeTrailingWhitespace($tokens->getPrevMeaningfulToken($closeBraceIndex));
     }
 
-    private function mergeArgs(Tokens $tokens, $index)
+    private function mergeArgs(Tokens $tokens, $index): void
     {
         $openBraceIndex  = $tokens->getNextTokenOfKind($index, ['(']);
         $closeBraceIndex = $this->analyze($tokens)->getClosingParenthesis($openBraceIndex);

src/PedroTroller/CS/Fixer/CodingStyle/LineBreakBetweenStatementsFixer.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace PedroTroller\CS\Fixer\CodingStyle;
 
 use PedroTroller\CS\Fixer\AbstractFixer;
@@ -64,14 +66,14 @@ public function getDocumentation()
         return 'Transform multiline docblocks with only one comment into a singleline docblock.';
     }
 
-    protected function applyFix(SplFileInfo $file, Tokens $tokens)
+    protected function applyFix(SplFileInfo $file, Tokens $tokens): void
     {
         foreach ($tokens->findGivenKind(array_keys($this->handlers)) as $kind => $matchedTokens) {
             $this->{'handle'.ucfirst($this->handlers[$kind])}($matchedTokens, $tokens);
         }
     }
 
-    private function handleDo(array $matchedTokens, Tokens $tokens)
+    private function handleDo(array $matchedTokens, Tokens $tokens): void
     {
         foreach ($matchedTokens as $index => $token) {
             $this->fixSpaces(
@@ -81,7 +83,7 @@ private function handleDo(array $matchedTokens, Tokens $tokens)
         }
     }
 
-    private function handleCommon(array $matchedTokens, Tokens $tokens)
+    private function handleCommon(array $matchedTokens, Tokens $tokens): void
     {
         foreach ($matchedTokens as $index => $token) {
             $curlyBracket = $tokens->findSequence([
@@ -111,7 +113,7 @@ private function handleCommon(array $matchedTokens, Tokens $tokens)
         }
     }
 
-    private function fixSpaces($index, Tokens $tokens)
+    private function fixSpaces($index, Tokens $tokens): void
     {
         $space = $index + 1;
 

src/PedroTroller/CS/Fixer/Comment/CommentLineToPhpdocBlockFixer.php

@@ -85,7 +85,7 @@ public function getPriority()
     /**
      * {@inheritdoc}
      */
-    protected function applyFix(SplFileInfo $file, Tokens $tokens)
+    protected function applyFix(SplFileInfo $file, Tokens $tokens): void
     {
         $elements = $this->analyze($tokens)->getClassyElements();
 

src/PedroTroller/CS/Fixer/Comment/SingleLineCommentFixer.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace PedroTroller\CS\Fixer\Comment;
 
 use PedroTroller\CS\Fixer\AbstractFixer;
@@ -96,7 +98,7 @@ public function getDeprecationReplacement()
     /**
      * {@inheritdoc}
      */
-    protected function applyFix(SplFileInfo $file, Tokens $tokens)
+    protected function applyFix(SplFileInfo $file, Tokens $tokens): void
     {
         $this->{$this->configuration['action'].'Comment'}($tokens);
     }
@@ -117,7 +119,7 @@ protected function createConfigurationDefinition()
         ]);
     }
 
-    private function expandedComment(Tokens $tokens)
+    private function expandedComment(Tokens $tokens): void
     {
         foreach ($this->getComments($tokens) as $index => $token) {
             $space = '';
@@ -135,7 +137,7 @@ private function expandedComment(Tokens $tokens)
         }
     }
 
-    private function collapsedComment(Tokens $tokens)
+    private function collapsedComment(Tokens $tokens): void
     {
         foreach ($this->getComments($tokens) as $index => $token) {
             foreach ($this->configuration['types'] as $variable) {

src/PedroTroller/CS/Fixer/Comment/UselessCommentFixer.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace PedroTroller\CS\Fixer\Comment;
 
 use PedroTroller\CS\Fixer\AbstractFixer;
@@ -78,7 +80,7 @@ public function getDeprecationReplacement()
     /**
      * {@inheritdoc}
      */
-    protected function applyFix(SplFileInfo $file, Tokens $tokens)
+    protected function applyFix(SplFileInfo $file, Tokens $tokens): void
     {
         foreach ($this->analyze($tokens)->getClassyElements() as $index => $element) {
             if ('method' !== $element['type']) {

src/PedroTroller/CS/Fixer/DeadCode/UselessCodeAfterReturnFixer.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace PedroTroller\CS\Fixer\DeadCode;
 
 use PedroTroller\CS\Fixer\AbstractFixer;
@@ -72,7 +74,7 @@ public function buildCallable()
     /**
      * {@inheritdoc}
      */
-    protected function applyFix(SplFileInfo $file, Tokens $tokens)
+    protected function applyFix(SplFileInfo $file, Tokens $tokens): void
     {
         $returns  = $tokens->findGivenKind(T_RETURN);
         $analyzer = $this->analyze($tokens);

src/PedroTroller/CS/Fixer/DoctrineMigrationsFixer.php

@@ -111,13 +111,13 @@ protected function createConfigurationDefinition()
     /**
      * {@inheritdoc}
      */
-    protected function applyFix(SplFileInfo $file, Tokens $tokens)
+    protected function applyFix(SplFileInfo $file, Tokens $tokens): void
     {
         $this->removeUselessGetDocumentation($tokens);
         $this->removeUselessComments($tokens);
     }
 
-    private function removeUselessGetDocumentation(Tokens $tokens)
+    private function removeUselessGetDocumentation(Tokens $tokens): void
     {
         foreach ($this->analyze($tokens)->getElements() as $element) {
             if ('method' !== $element['type']) {
@@ -157,7 +157,7 @@ private function removeUselessGetDocumentation(Tokens $tokens)
         }
     }
 
-    private function removeUselessComments(Tokens $tokens)
+    private function removeUselessComments(Tokens $tokens): void
     {
         $comments = $this->getComments($tokens);
 

src/PedroTroller/CS/Fixer/Fixers.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace PedroTroller\CS\Fixer;
 
 use IteratorAggregate;

src/PedroTroller/CS/Fixer/Phpspec/OrderedSpecElementsFixer.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace PedroTroller\CS\Fixer\Phpspec;
 
 use PedroTroller\CS\Fixer\AbstractOrderedClassElementsFixer;